Skip to content

check-code-style check should not block PRs on pre-existing issues #36

@CodingCanuck

Description

@CodingCanuck

3rdparty/stout#26 reports how pre-existing code format warnings block merging PRs that only touch unrelated files.

Can/should we change the check-code-style check to only complain about issues in files included in the PR to avoid unnecessary blocks?

I think it's totally valid to reject this suggestion, and instead we could declare that we should fix warnings at HEAD before submitting new work in order to keep head clean. (But if that's our stance, we should clean HEAD before turning on this check in any repos!)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions