From 995c2e2ee8d4617e54bac56577ac821e52c59bfb Mon Sep 17 00:00:00 2001
From: ankprasa <ankprasa@amd.com>
Date: Wed, 6 May 2026 17:36:56 +0000
Subject: [PATCH] bmcweb: Add 'revision' for Storage URI

revision was missing from the Storage Info.
Added the code to fetch revision.

Tested: On Congo. Revision is fetched.

'''

{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive0",
"@odata.type": "#Drive.v1_7_0.Drive",
"CapacityBytes": 1000204886016,
"Id": "Drive0",
"Links": {
"Chassis": {
"@odata.id": "/redfish/v1/Chassis/HPM"
}
},
"Manufacturer": "Samsung SSD 990 EVO 1TB ",
"MediaType": "NVMe",
"Model": "Samsung SSD 990 EVO 1TB ",
"Name": "Drive0",
"Revision": "0B2QKXJ7",
"SerialNumber": "S7M3NS0Y210852A ",
"Status": {
"State": "Enabled"
}
}

'''

Signed-off-by: ankprasa <ankprasa@amd.com>
---
 redfish-core/lib/storage.hpp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/redfish-core/lib/storage.hpp b/redfish-core/lib/storage.hpp
index 7ddc77a2d8..5a6a760a47 100644
--- a/redfish-core/lib/storage.hpp
+++ b/redfish-core/lib/storage.hpp
@@ -311,11 +311,12 @@ inline void getDriveAsset(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
             const std::string* serialNumber = nullptr;
             const std::string* manufacturer = nullptr;
             const std::string* model = nullptr;
+            const std::string* revision = nullptr;
 
             const bool success = sdbusplus::unpackPropertiesNoThrow(
                 dbus_utils::UnpackErrorPrinter(), propertiesList, "PartNumber",
                 partNumber, "SerialNumber", serialNumber, "Manufacturer",
-                manufacturer, "Model", model);
+                manufacturer, "Model", model, "Revision", revision);
 
             if (!success)
             {
@@ -342,6 +343,11 @@ inline void getDriveAsset(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
             {
                 asyncResp->res.jsonValue["Model"] = *model;
             }
+
+            if (revision != nullptr)
+            {
+                asyncResp->res.jsonValue["Revision"] = *revision;
+            }
         });
 }