Skip to content

ignore line spacing flag does not work #754

@ZERICO2005

Description

@ZERICO2005

details mentioned here:
#661


Doing a search on github for fontlib_SetFont https://github.com/search?q=fontlib_SetFont&type=code
I found these results:

So it seems like most users did not use the FONTLIB_IGNORE_LINE_SPACING flag, but fontlib_SetFont(font, 0) has a 99.6% chance as being treated as fontlib_SetFont(font, FONTLIB_IGNORE_LINE_SPACING)


My proposal is to:

  • Have fontlib_SetFont ignore line spacing with a 100% chance instead of a 99.6% chance.
  • Create a new routine (fontlib_LoadFont or etc) that properly handles the flags.
  • Discourage fontlib_SetFont in new code
  • Rename fontlib_SetFont to fontlib_Deprecated or etc, and have #define fontlib_SetFont fontlib_Deprecated with a warning so developers can update their code

Metadata

Metadata

Assignees

Labels

buglib/fontlibcIssues related to the font rendering library

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions