-
-
Notifications
You must be signed in to change notification settings - Fork 65
Open
Labels
buglib/fontlibcIssues related to the font rendering libraryIssues related to the font rendering library
Description
details mentioned here:
#661
Doing a search on github for fontlib_SetFont https://github.com/search?q=fontlib_SetFont&type=code
I found these results:
fontlib_SetFont(font, 0): at least 25 timesfontlib_SetFont(font, FONTLIB_IGNORE_LINE_SPACING): used only once in https://github.com/the-real-mcarn/stopresisting-ti84
So it seems like most users did not use the FONTLIB_IGNORE_LINE_SPACING flag, but fontlib_SetFont(font, 0) has a 99.6% chance as being treated as fontlib_SetFont(font, FONTLIB_IGNORE_LINE_SPACING)
My proposal is to:
- Have
fontlib_SetFontignore line spacing with a 100% chance instead of a 99.6% chance. - Create a new routine (
fontlib_LoadFontor etc) that properly handles the flags. - Discourage
fontlib_SetFontin new code - Rename
fontlib_SetFonttofontlib_Deprecatedor etc, and have#define fontlib_SetFont fontlib_Deprecatedwith a warning so developers can update their code
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
buglib/fontlibcIssues related to the font rendering libraryIssues related to the font rendering library