Features not defined in module revision leads to reject of the entire module

[catalinvlad192]

Hi!

Version 5.8.6

lys_set_features() rejects the entire module if any requested feature is absent (schema_features.c:606-611)

if (!lysp_feature_find(pmod, features[j], strlen(features[j]), 0)) {
    LOGERR(pmod->mod->ctx, LY_EINVAL, "Feature \"%s\" not found in module \"%s@%s\".", features[j], pmod->mod->name, pmod->mod->revision ? pmod->mod->revision : "<none>");
    return LY_EINVAL;
}

Is this done by design? Shouldn't a client use its own known revisions and ignore the ones it doesn't know?
Thank you!

[michalvasko]

Trying to enable a non-existing feature is a major error condition, we believe, so the function intentionally does not make any changes then.