You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 14, 2023. It is now read-only.
This Issue serves as documentation for anticipated breaking changes in 3.0 and allows community feedback to drive the development process.
Breaking Changes 💔
Do not re-export React from reactn. Have users just import React and ReactN Component/hooks from separate packages. This will help with the namespace conflicts with Component in TypeScript.
Remove support for @reactn decorator. Typing the decorator is difficult to maintain, and the feature is not often (if ever?) used.
Property reducers/dispatchers to be moved to addPropertyReducer and usePropertyDispatch instead of sharing a namespace with addReducer and useDispatch.
New Features ✨
Since the decorator is removed, the project can be pure TypeScript with the "as MagicType" happening in src/index.ts.
Since addPropertyReducer is given its own helper function, the property can be tightly coupled at the global level. addPropertyReducer(property, reducer) would be synonymous with addReducer((global, dispatch, ...args) => ({ [property]: reducer(global[property], ...args) })). This may make some reducers easier to write.
useSelector('id') as a simplified way to grab global.x.y.z.mutate(f).
Update the /docs app to reflect 3.0 as development occurs.
Try to officialize type Reducers = typeof reducers in reactn/global.d.ts.
Use a different helper function for adding reducers that dispatch other actions.
function reducer(global, ...args) and function reducer(global, dispatch, ...args) should both be acceptable ways to write a reducer.
Forcing users to write the latter is annoying when the majority of reducers do not use the dispatch parameter.
This would require a verbiage change to describe reducers that dispatch and reducers that don't, e.g. addReducer and addSaga.
Come up with solid verbiage for actions, reducers, dispatchers. The concept that actions and reducers are tightly coupled is not immediately obvious to users.
Can the saga pattern be officialized? The global state manager has a concept of building up state changes before committing them. Should a commit/rollback method be exposed to saga reducers to allow them to build state before finalizing/committing it? Is the desired behavior of sagas to finish multiple state changes before re-rendering, or should the UI re-render as the state changes and the UI rolls back as the saga rolls back?
Support deep-nested listeners? Perhaps only for objects that share an immediately prototype with Object or null, i.e. not instances of Error, etc. useGlobal('x', 'y', 'z'). On state change, check all global subscriptions for shallow keys, then check all matches for shallow key changes. Implementation direction could use fleshing out.
This Issue serves as documentation for anticipated breaking changes in 3.0 and allows community feedback to drive the development process.
Breaking Changes 💔
reactn. Have users just import React and ReactN Component/hooks from separate packages. This will help with the namespace conflicts withComponentin TypeScript.@reactndecorator. Typing the decorator is difficult to maintain, and the feature is not often (if ever?) used.addPropertyReducerandusePropertyDispatchinstead of sharing a namespace withaddReduceranduseDispatch.New Features ✨
src/index.ts.addPropertyReduceris given its own helper function, the property can be tightly coupled at the global level.addPropertyReducer(property, reducer)would be synonymous withaddReducer((global, dispatch, ...args) => ({ [property]: reducer(global[property], ...args) })). This may make some reducers easier to write.useSelector('id')as a simplified way to grabglobal.x.y.z.mutate(f)./docsapp to reflect 3.0 as development occurs.Undecided 📃
type Reducers = typeof reducersinreactn/global.d.ts.function reducer(global, ...args)andfunction reducer(global, dispatch, ...args)should both be acceptable ways to write a reducer.addReducerandaddSaga.Error, etc.useGlobal('x', 'y', 'z'). On state change, check all global subscriptions for shallow keys, then check all matches for shallow key changes. Implementation direction could use fleshing out.