todesktop-beforeBuild.cjs

// Keys are todesktop's normalized `${platform}-${arch}` strings (matches
// electron-builder's Platform enum: windows / mac / linux), NOT Node's
// process.platform values (win32 / darwin / linux). Until this was fixed,
// every Windows and Mac build silently hit the "skipping" branch below —
// the fetch on todesktop's server never ran, which is why 0.6.4 (and every
// earlier release with this hook) shipped without bootstrap-python.
const PLATFORM_MAP = {
  'windows-x64': 'win-x64',
  // Native Windows on Arm build (NVIDIA RTX Spark). Until bootstrap-v3 this
  // shipped the x64 bootstrap under Prism emulation; the native ARM64
  // python.exe runs git operations without the emulation layer.
  'windows-arm64': 'win-arm64',
  'mac-arm64': 'mac-arm64',
  'linux-x64': 'linux-x64',
}

// Each platform's expected Python binary inside its bootstrap-python dir.
// Mirrors PYTHON_BINARY in fetch-bootstrap-python.mjs and the runtime check
// in src/main/lib/git.ts:tryConfigureBootstrapPygit2. Kept here so a fetch
// script that returns 0 but produces a directory without the binary still
// fails the build instead of silently shipping a broken installer.
// Forward slashes are fine on every platform — these strings are passed to
// path.join() below, which normalizes separators per-OS.
const PYTHON_BINARY = {
  'win-x64': 'python.exe',
  'win-arm64': 'python.exe',
  'mac-arm64': 'bin/python3',
  'linux-x64': 'bin/python3',
}

// Mirrors UV_BINARY in fetch-bootstrap-python.mjs and uvDestRel in
// build-bootstrap-python.mjs. Verified here too so that a fetch returning
// success without uv (e.g. accidentally re-tagging a pre-v2 archive at the
// current default tag) fails the build instead of shipping a launcher whose
// adopted-install flows have no usable package manager.
const UV_BINARY = {
  'win-x64': 'uv.exe',
  'win-arm64': 'uv.exe',
  'mac-arm64': 'bin/uv',
  'linux-x64': 'bin/uv',
}

module.exports = async ({ appDir, platform, arch }) => {
  const { execSync } = await import('node:child_process')
  const fs = await import('node:fs')
  const path = await import('node:path')

  const key = `${platform}-${arch}`
  const bootstrapPlatform = PLATFORM_MAP[key]
  if (!bootstrapPlatform) {
    console.log(`[todesktop:beforeBuild] No bootstrap python for ${key}, skipping`)
    return
  }

  console.log(`[todesktop:beforeBuild] Fetching bootstrap python for ${bootstrapPlatform}`)
  const script = path.join(appDir, 'scripts', 'fetch-bootstrap-python.mjs')
  // todesktop layout:
  //   <workingDir>/app-wrapper/app/         <- this is `appDir` (electron-builder appDirectory)
  //   <workingDir>/app-wrapper/extraResources/  <- where extraResources.from is staged from
  // extraResources.from in todesktop.json resolves against `app-wrapper/extraResources/`,
  // NOT against the project root. The v0.6.6 mac build log proved this: the hook
  // verified the binary inside `app-wrapper/app/extraResources/...` (correct relative
  // to `appDir`) but electron-builder still warned `file source doesn't exist
  // from=app-wrapper/extraResources/...` — and the dmg shipped without bootstrap-python.
  // Going up one level from `appDir` puts the archive where todesktop actually reads it.
  const outDir = path.join(appDir, '..', 'extraResources', 'bootstrap-python')
  // fetch-bootstrap-python.mjs now exits non-zero on failure, which bubbles
  // up here via execSync. Don't wrap in try/catch — a failed fetch must fail
  // the build (see 0.6.4 post-mortem: a swallowed fetch error shipped an
  // installer with no bootstrap-python, stranding new installs).
  execSync(
    `node "${script}" --platform ${bootstrapPlatform} --output-dir "${outDir}"`,
    { stdio: 'inherit', cwd: appDir }
  )

  // Defense-in-depth: even if the fetch script returns success, verify the
  // expected binaries exist before handing control back to todesktop. A
  // divergence between the fetch script's success criteria and what the app
  // looks for at runtime would otherwise reproduce the same silent failure.
  const expectedPython = path.join(outDir, bootstrapPlatform, PYTHON_BINARY[bootstrapPlatform])
  if (!fs.existsSync(expectedPython)) {
    throw new Error(
      `[todesktop:beforeBuild] fetch script returned success but ${expectedPython} is missing. ` +
      `Refusing to build — the installer would not provide a git backend and "Latest Stable" ` +
      `installs would silently strand on the bundled ComfyUI version.`
    )
  }
  const expectedUv = path.join(outDir, bootstrapPlatform, UV_BINARY[bootstrapPlatform])
  if (!fs.existsSync(expectedUv)) {
    throw new Error(
      `[todesktop:beforeBuild] fetch script returned success but ${expectedUv} is missing. ` +
      `Refusing to build — the bootstrap archive predates bootstrap-v2 (no bundled uv). ` +
      `Bump the default tag in fetch-bootstrap-python.mjs or publish the v2 archives.`
    )
  }
  console.log(`[todesktop:beforeBuild] Verified ${expectedPython} and ${expectedUv}`)
}