11import { handleRequest , makeVerifier , type Options , unavailable as logged } from "@effect/chat-slack/internal/webhook"
22import * as SlackChat from "@effect/chat-slack/SlackChat"
3+ import * as NodeCrypto from "@effect/platform-node/NodeCrypto"
34import { assert , describe , it } from "@effect/vitest"
45import * as Chat from "effect/chat/Chat"
56import { ChatError , PlatformUnavailable } from "effect/chat/ChatError"
67import type * as ChatEvent from "effect/chat/ChatEvent"
78import { ChatHandler , NotAccepted } from "effect/chat/ChatHandler"
9+ import * as CryptoError from "effect/crypto/CryptoError"
10+ import * as Mac from "effect/crypto/Mac"
811import * as Duration from "effect/Duration"
912import * as Effect from "effect/Effect"
1013import * as Fiber from "effect/Fiber"
@@ -56,7 +59,7 @@ const request = async (body: string, options?: { readonly timestamp?: string; re
5659const message = messageEnvelope ( { ts : "1794509003.000001" , user : "U080YLYB277" , text : "hi <@U0CCLMD4S1L>" } )
5760
5861const handle = Effect . fnUntraced ( function * ( options : Partial < Options > , web : Request ) {
59- const verify = yield * makeVerifier ( Redacted . make ( secret ) )
62+ const verify = yield * makeVerifier ( Redacted . make ( secret ) ) . pipe ( Effect . provide ( NodeCrypto . layerMac ) )
6063 const events : Array < ChatEvent . ChatEvent > = [ ]
6164 const response = yield * handleRequest ( HttpServerRequest . fromWeb ( web ) , {
6265 verify,
@@ -94,6 +97,11 @@ describe("webhook", () => {
9497 assert . strictEqual ( old . status , 401 )
9598 const unsigned = yield * handle ( { } , new Request ( "http://localhost/" , { method : "POST" , body } ) )
9699 assert . strictEqual ( unsigned . status , 401 )
100+ for ( const signature of [ "00" , "v0=0" , "v0=gg" , "v0=00" ] ) {
101+ const web = yield * Effect . promise ( ( ) => request ( body ) )
102+ web . headers . set ( "x-slack-signature" , signature )
103+ assert . strictEqual ( ( yield * handle ( { } , web ) ) . status , 401 )
104+ }
97105 assert . strictEqual ( wrongKey . events . length + old . events . length + unsigned . events . length , 0 )
98106 } ) )
99107
@@ -170,6 +178,7 @@ describe("webhook", () => {
170178 } ) . pipe (
171179 Layer . provide ( SlackChat . layer ( { botToken : Redacted . make ( "xoxb-test" ) , teamId : team } ) ) ,
172180 Layer . provide ( Chat . layer ) ,
181+ Layer . provide ( NodeCrypto . layerMac ) ,
173182 Layer . provide ( Layer . succeed ( ChatHandler , { handle : ( event ) => Effect . sync ( ( ) => void events . push ( event ) ) } ) ) ,
174183 Layer . provide ( fake . layer )
175184 )
@@ -196,18 +205,46 @@ describe("webhook", () => {
196205 assert . isTrue ( cancelled )
197206 } ) )
198207
199- it . live ( "layerWebhook serves the path " , ( ) =>
208+ it . live ( "layerWebhook uses the supplied Mac and fails closed on crypto errors " , ( ) =>
200209 Effect . gen ( function * ( ) {
201210 const fake = makeFake ( { "auth.test" : authTest } )
202211 const events : Array < ChatEvent . ChatEvent > = [ ]
212+ let fail = false
213+ const mac = Layer . succeed ( Mac . Mac , {
214+ generateKey : ( ) => Effect . die ( "unused" ) ,
215+ sign : ( ) => Effect . die ( "unused" ) ,
216+ verify : Effect . fnUntraced ( function * ( key , tag , data ) {
217+ assert . strictEqual ( key . algorithm , Mac . hmacSha256 )
218+ assert . deepStrictEqual ( tag , new Uint8Array ( [ 0xab , 0xcd ] ) )
219+ assert . strictEqual ( new TextDecoder ( ) . decode ( yield * Mac . toBytes ( key ) ) , secret )
220+ assert . strictEqual ( new TextDecoder ( ) . decode ( data ) . split ( ":" ) . slice ( 2 ) . join ( ":" ) , JSON . stringify ( message ) )
221+ return yield * fail
222+ ? Effect . fail (
223+ new CryptoError . CryptoError ( {
224+ module : "Mac" ,
225+ method : "verify" ,
226+ reason : new CryptoError . InvalidKey ( { description : "test failure" } )
227+ } )
228+ )
229+ : Effect . succeed ( true )
230+ } )
231+ } )
203232 const app = SlackChat . layerWebhook ( { path : "/slack/events" , signingSecret : Redacted . make ( secret ) , appId } ) . pipe (
204233 Layer . provide ( SlackChat . layer ( { botToken : Redacted . make ( "xoxb-test" ) , teamId : team } ) ) ,
205234 Layer . provide ( Chat . layer ) ,
235+ Layer . provide ( mac ) ,
206236 Layer . provide ( Layer . succeed ( ChatHandler , { handle : ( event ) => Effect . sync ( ( ) => void events . push ( event ) ) } ) ) ,
207237 Layer . provide ( fake . layer )
208238 )
209239 const { dispose, handler } = HttpRouter . toWebHandler ( app , { disableLogger : true } )
210- const response = yield * Effect . promise ( ( ) => request ( JSON . stringify ( message ) ) . then ( ( web ) => handler ( web ) ) )
240+ const send = Effect . promise ( async ( ) => {
241+ const web = await request ( JSON . stringify ( message ) )
242+ web . headers . set ( "x-slack-signature" , "v0=abcd" )
243+ return handler ( web )
244+ } )
245+ const response = yield * send
246+ fail = true
247+ assert . strictEqual ( ( yield * send ) . status , 401 )
211248 yield * Effect . promise ( ( ) => dispose ( ) )
212249 assert . strictEqual ( response . status , 200 )
213250 assert . strictEqual ( events . length , 1 )
0 commit comments