Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 029d10a The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
CloudflareSchedulerfor Worker applications that share fibers across requests. It uses synchronous scheduling and disables native async-context capture. The module documents runner and sharedManagedRuntimeinstallation, plus the async-context, CPU, and request-owned I/O limitations.A platform-only scheduler could not bypass the unconditional captures in core. After discussing that constraint with Team Lead, this adds the optional
Scheduler.preserveAsyncContextflag at both suspension and deferred-fork capture sites. Omission preserves existing behavior; there is no runtime detection or catch-and-retry.Review follow-up: TestClock forwards the parent scheduler’s context policy. The ManagedRuntime recipe now requires runner options as well as the layer, covering callers waiting on lazy initialization; both review failures were reproduced before fixing them.
Validation
Effect.test.ts,TestClock.test.ts, andCloudflareScheduler.test.ts, including inherited fork behavior, default native-context propagation, and TestClock forwarding the opt-out.nodejs_compat: restoring capture produces the reported request-bound AsyncLocalStorage error and HTTP 500; the Cloudflare scheduler completes both a shared fiber and lazy ManagedRuntime initialization across requests.pnpm check,pnpm lint-fix,pnpm lint, andpnpm jsdocs --checkpassed (all vianix develop -c).The regression uses a test-only Miniflare v5 alias matching the version already used by core and SQL tests. Existing Cloudflare integration tests retain their v4 dependency and API.
Both packages have minor changesets because these are additive stable APIs.
Closes EFF-3794