Skip to content

Provide the app's services to the server in HttpRouter.serve - #10668

Open
0xh3x wants to merge 3 commits into
Effect-TS:mainfrom
0xh3x:fix/http-router-serve-provide-app-context
Open

0xh3x wants to merge 3 commits into
Effect-TS:mainfrom
0xh3x:fix/http-router-serve-provide-app-context

Conversation

@0xh3x

@0xh3x 0xh3x commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Since #8477, HttpRouter.serve merges the app's built context beside HttpServer.serve instead of providing it to it, so request fibers run without the app's services. As a result:

  • references set in the app (e.g. HttpMiddleware.TracerDisabledWhen) are ignored by the server-level tracer and logger
  • Effect.provide in a handler rebuilds layers the app already built, because the forked memo map is missing
import { NodeHttpServer } from "@effect/platform-node"
import { Context, Effect, Layer, Tracer } from "effect"
import { HttpClient, HttpMiddleware, HttpRouter, HttpServerResponse } from "effect/http"

class Counter extends Context.Service<Counter, { readonly id: number }>()("Counter") {}
let builds = 0
const CounterLayer = Layer.sync(Counter)(() => ({ id: ++builds }))

const App = Layer.mergeAll(
  // a server-level reference set in the app
  Layer.succeed(HttpMiddleware.TracerDisabledWhen)(() => true),
  // a layer the app builds once...
  Layer.effectDiscard(Effect.service(Counter)).pipe(Layer.provide(CounterLayer)),
  // ...and a handler that provides it again
  HttpRouter.add(
    "GET",
    "/",
    Effect.service(Counter).pipe(
      Effect.provide(CounterLayer),
      Effect.map((counter) => HttpServerResponse.text(String(counter.id)))
    )
  )
)

let serverSpans = 0
const tracer = Tracer.make({
  span: (options) => {
    if (options.kind === "server") serverSpans++
    return new Tracer.NativeSpan(options)
  }
})

Effect.gen(function*() {
  const client = yield* HttpClient.HttpClient
  const get = client.get("/").pipe(Effect.flatMap((response) => response.text))
  console.log({ ids: [yield* get, yield* get], builds, serverSpans })
}).pipe(
  Effect.provide(
    HttpRouter.serve(App, { disableListenLog: true, disableLogger: true }).pipe(
      Layer.provideMerge(NodeHttpServer.layerTest)
    )
  ),
  Effect.provideService(Tracer.Tracer, tracer),
  Effect.runPromise
)
// main:        { ids: [ '2', '3' ], builds: 3, serverSpans: 2 }
// this branch: { ids: [ '1', '1' ], builds: 1, serverSpans: 0 }

Changes

Layer.merge → Layer.provideMerge in serve, so the server layer also receives the app's context. Layer.buildWithMemoMap already adds the forked CurrentMemoMap to that context, which covers both effects.

This restores what serve did before #8477 and matches toWebHandler, which already runs requests with the built context. Router isolation from #8460 is unchanged: each serve still builds its own router in its own forked memo map ("keeps routes isolated between independent servers" passes). Layers the app did not build are still built per request.

If you'd rather not forward the memo map to request fibers, providing the context without CurrentMemoMap fixes the references only.

Validated with pnpm lint-fix, pnpm check, and the Node and Deno HTTP server tests.

Closes EFF-3840

HttpRouter.serve merged the app's built context beside HttpServer.serve
instead of providing it, so request fibers ran without the app's
services. References set in the app (such as TracerDisabledWhen) were
ignored by the server-level tracer and logger, and Effect.provide inside
a handler rebuilt layers the app had already built because the forked
memo map was missing from the request context.
@changeset-bot

changeset-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 861620d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-amazon-bedrock Patch
@effect/ai-anthropic Patch
@effect/ai-cloudflare Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-cloudflare Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/graphql-generator Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-janitor effect-janitor Bot added the 4.0 label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 40.09 KB 40.09 KB 0.00 KB (0.00%)
basic.ts 7.31 KB 7.31 KB 0.00 KB (0.00%)
batching.ts 11.21 KB 11.21 KB 0.00 KB (0.00%)
brand.ts 7.00 KB 7.00 KB 0.00 KB (0.00%)
cache.ts 11.73 KB 11.73 KB 0.00 KB (0.00%)
config.ts 23.09 KB 23.09 KB 0.00 KB (0.00%)
differ.ts 22.20 KB 22.20 KB 0.00 KB (0.00%)
http-client.ts 27.45 KB 27.45 KB 0.00 KB (0.00%)
http-router.ts 37.59 KB 37.59 KB 0.00 KB (0.00%)
logger.ts 12.19 KB 12.19 KB 0.00 KB (0.00%)
metric.ts 9.65 KB 9.65 KB 0.00 KB (0.00%)
optic.ts 7.21 KB 7.21 KB 0.00 KB (0.00%)
pubsub.ts 16.21 KB 16.21 KB 0.00 KB (0.00%)
queue.ts 13.09 KB 13.09 KB 0.00 KB (0.00%)
schedule.ts 11.99 KB 11.99 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 14.29 KB 14.29 KB 0.00 KB (0.00%)
schema-binary.ts 42.48 KB 42.48 KB 0.00 KB (0.00%)
schema-class.ts 21.96 KB 21.96 KB 0.00 KB (0.00%)
schema-codegen.ts 30.70 KB 30.70 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 30.56 KB 30.56 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 28.26 KB 28.26 KB 0.00 KB (0.00%)
schema-string-transformation.ts 15.54 KB 15.54 KB 0.00 KB (0.00%)
schema-string.ts 12.50 KB 12.50 KB 0.00 KB (0.00%)
schema-template-literal.ts 16.43 KB 16.43 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 39.63 KB 39.63 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 21.11 KB 21.11 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 21.28 KB 21.28 KB 0.00 KB (0.00%)
schema-toFormatter.ts 21.37 KB 21.37 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 26.42 KB 26.42 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 21.45 KB 21.45 KB 0.00 KB (0.00%)
schema.ts 21.05 KB 21.05 KB 0.00 KB (0.00%)
stm.ts 14.46 KB 14.46 KB 0.00 KB (0.00%)
stream.ts 10.56 KB 10.56 KB 0.00 KB (0.00%)

This branch is waiting to be deployed

1 waiting deployment
fork — 861620da Waiting Nov 17, 2026 by effect-bot via approval-gate #26458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants