Repository navigation
Conversation
HttpRouter.serve merged the app's built context beside HttpServer.serve instead of providing it, so request fibers ran without the app's services. References set in the app (such as TracerDisabledWhen) were ignored by the server-level tracer and logger, and Effect.provide inside a handler rebuilt layers the app had already built because the forked memo map was missing from the request context.
🦋 Changeset detectedLatest commit: 861620d The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #8477,
HttpRouter.servemerges the app's built context besideHttpServer.serveinstead of providing it to it, so request fibers run without the app's services. As a result:HttpMiddleware.TracerDisabledWhen) are ignored by the server-level tracer and loggerEffect.providein a handler rebuilds layers the app already built, because the forked memo map is missingChanges
Layer.merge→Layer.provideMergeinserve, so the server layer also receives the app's context.Layer.buildWithMemoMapalready adds the forkedCurrentMemoMapto that context, which covers both effects.This restores what
servedid before #8477 and matchestoWebHandler, which already runs requests with the built context. Router isolation from #8460 is unchanged: eachservestill builds its own router in its own forked memo map ("keeps routes isolated between independent servers" passes). Layers the app did not build are still built per request.If you'd rather not forward the memo map to request fibers, providing the context without
CurrentMemoMapfixes the references only.Validated with
pnpm lint-fix,pnpm check, and the Node and Deno HTTP server tests.Closes EFF-3840