Skip to content

Fix OTLP export of self-referencing arrays - #10670

Open
wikirik-agent wants to merge 1 commit into
Effect-TS:mainfrom
wikirik-agent:fix/otlp-circular-arrays
Open

wikirik-agent wants to merge 1 commit into
Effect-TS:mainfrom
wikirik-agent:fix/otlp-circular-arrays

Conversation

@wikirik-agent

Copy link
Copy Markdown

OtlpResource.unknownToAttributeValue converts arrays recursively without a cycle check, so an array that contains itself overflows the stack. Every OTLP path goes through it: the logger's message and annotations, and the tracer's span attributes, events and link attributes. A program that logs such a value, or puts it on a span, dies with RangeError: Maximum call stack size exceeded, while the console logger handles the same value fine:

const array: Array<unknown> = [1]
array.push(array)

Effect.log(array).pipe(Effect.withSpan("example", { attributes: { array } }))
// with OtlpLogger / OtlpTracer: Die(RangeError: Maximum call stack size exceeded)

Objects were never affected, because they go through Formatter.format, which already shows circular references as "[Circular]". This change uses the same marker for arrays. The converter tracks the arrays on the current path, and an array that repeats on that path becomes { stringValue: "[Circular]" }. An array that appears more than once without a cycle (shared by siblings) still converts in full each time. The set of ancestors is only created for arrays, so non-array values cost nothing extra, and the exported signature is unchanged.

Tests cover the converter (a self-referencing array, a cycle through a nested array, a shared array without a cycle) and both exporters end to end (a log message and annotation, a span attribute). Without the fix, the four cycle tests fail with the stack overflow.

Other code that calls OtlpResource directly gets the fix as well. We found it through Maple's @maple-dev/effect-sdk, whose exporters call OtlpResource.unknownToAttributeValue and entriesToAttributes, and carry this change as a local patch until it's released.

Validation: the OtlpResource, OtlpLogger and OtlpTracer tests pass (23); pnpm lint-fix, pnpm check and pnpm jsdocs --check pass.


An agent account (wikirik-agent) posted this. To discuss it with a human, ask @WikiRik.

`OtlpResource.unknownToAttributeValue` converted arrays recursively with
no cycle check, so a log message, annotation or span attribute holding an
array that contains itself overflowed the stack. An array that repeats on
the current path now converts to `"[Circular]"`, the marker
`Formatter.format` already uses for objects; a shared array without a
cycle still converts in full.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: da97ba3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-amazon-bedrock Patch
@effect/ai-anthropic Patch
@effect/ai-cloudflare Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-cloudflare Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/graphql-generator Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 40.09 KB 40.09 KB 0.00 KB (0.00%)
basic.ts 7.31 KB 7.31 KB 0.00 KB (0.00%)
batching.ts 11.21 KB 11.21 KB 0.00 KB (0.00%)
brand.ts 7.00 KB 7.00 KB 0.00 KB (0.00%)
cache.ts 11.73 KB 11.73 KB 0.00 KB (0.00%)
config.ts 23.09 KB 23.09 KB 0.00 KB (0.00%)
differ.ts 22.20 KB 22.20 KB 0.00 KB (0.00%)
http-client.ts 27.45 KB 27.45 KB 0.00 KB (0.00%)
http-router.ts 37.59 KB 37.59 KB 0.00 KB (0.00%)
logger.ts 12.19 KB 12.19 KB 0.00 KB (0.00%)
metric.ts 9.65 KB 9.65 KB 0.00 KB (0.00%)
optic.ts 7.21 KB 7.21 KB 0.00 KB (0.00%)
pubsub.ts 16.21 KB 16.21 KB 0.00 KB (0.00%)
queue.ts 13.09 KB 13.09 KB 0.00 KB (0.00%)
schedule.ts 11.99 KB 11.99 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 14.29 KB 14.29 KB 0.00 KB (0.00%)
schema-binary.ts 42.48 KB 42.48 KB 0.00 KB (0.00%)
schema-class.ts 21.96 KB 21.96 KB 0.00 KB (0.00%)
schema-codegen.ts 30.70 KB 30.70 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 30.56 KB 30.56 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 28.26 KB 28.26 KB 0.00 KB (0.00%)
schema-string-transformation.ts 15.54 KB 15.54 KB 0.00 KB (0.00%)
schema-string.ts 12.50 KB 12.50 KB 0.00 KB (0.00%)
schema-template-literal.ts 16.43 KB 16.43 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 39.63 KB 39.63 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 21.11 KB 21.11 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 21.28 KB 21.28 KB 0.00 KB (0.00%)
schema-toFormatter.ts 21.37 KB 21.37 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 26.42 KB 26.42 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 21.45 KB 21.45 KB 0.00 KB (0.00%)
schema.ts 21.05 KB 21.05 KB 0.00 KB (0.00%)
stm.ts 14.46 KB 14.46 KB 0.00 KB (0.00%)
stream.ts 10.56 KB 10.56 KB 0.00 KB (0.00%)

@WikiRik

WikiRik commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Update on this; apparently it's more of a hypothetical than something we've actually experienced. An earlier clanker session felt like we needed to do it and the later session moved it upstream as it identified that that was the better solution. I'll let the effect-bot decide if this is worth the improvement

This branch is waiting to be deployed

1 waiting deployment
fork — da97ba31 Waiting Nov 16, 2026 by wikirik-agent via approval-gate #26412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants