Repository navigation
Expose captured TestConsole warning, info, debug, and trace output - #10682
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 052f87c The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
warnLines,infoLines,debugLines, andtraceLinesreaders, preserving captured parameter values and call order.@since 4.1.5and sibling links.effectpatch changeset, following the accepted design.Compatibility
Existing
makeandlayerconsumers gain additive readers. Hand-written objects implementing the unstableTestConsoleinterface must supply the four new fields; the accepted design explicitly retains required fields.Validation
All commands run with
nix develop -c:pnpm test --run packages/effect/test/TestConsole.test.ts— 4 passed (previously all red in the test-only commit).pnpm checkpnpm lint-fixandpnpm lintpnpm jsdocs --checkpnpm doctest --run packages/effect/src/testing/TestConsole.ts— 8 passed.Separate review and Architect simplification passes will follow.
Closes #10665
Closes EFF-3836