Repository navigation
Clarify Effect interruption, cleanup, and fork guarantees - #10683
Merged
Merged
Conversation
|
Replace five copies of the registration-during-startup scenario with one helper, drive the cleanup matrix from a table, make each uninterruptible fork option row discriminate, and move the fork option and timeout tests beside their suites.
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the API-specific runtime guarantees requested in #10667, without changing runtime behavior or public signatures.
Effect.suspend, not a universal callback rule.acquireUseReleaseinterruptibility and the interruptedExitsupplied to release.migration/forking.mdwithout promising a scheduler turn.Review guide
9443a0f2bc: focused, Deferred-coordinated regression coverage in five existing suites (tests-only pass).The general callback-throw rule, inconsistent closed-container
runbehavior, loser interruption timing, and cleanup-failure aggregation are intentionally not broadened into guarantees. TheonWinnerthrown-callback inconsistency remains a separate runtime issue. Website updates outside this repository are not included.Validation
All commands run through
nix develop -c:pnpm jsdocs --checkpnpm lint-fixandpnpm lintpnpm checkpnpm test --runfor Effect, Fiber, FiberSet, FiberMap, and FiberHandle: 428 tests passedgit diff --checkNo changeset: this PR adds regression coverage and documents existing behavior; runtime code, exported signatures, and examples are unchanged.
Closes #10667
Closes EFF-3839