diff --git a/.changeset/fix-summary-nan-quantiles.md b/.changeset/fix-summary-nan-quantiles.md new file mode 100644 index 00000000000..49e3bde55f4 --- /dev/null +++ b/.changeset/fix-summary-nan-quantiles.md @@ -0,0 +1,5 @@ +--- +"effect": patch +--- + +Fix `Metric.summary` and `Metric.summaryWithTimestamp` accepting NaN quantiles. diff --git a/packages/effect/src/Metric.ts b/packages/effect/src/Metric.ts index b27b117f05b..4442d7a7d77 100644 --- a/packages/effect/src/Metric.ts +++ b/packages/effect/src/Metric.ts @@ -1956,7 +1956,7 @@ class SummaryMetric extends Metric$(this.#maxSize) for (const quantile of this.#quantiles) { - if (quantile < 0 || quantile > 1) { + if (!(quantile >= 0 && quantile <= 1)) { throw new Error(`Quantile must be between 0 and 1, found: ${quantile}`) } } diff --git a/packages/effect/test/Metric.test.ts b/packages/effect/test/Metric.test.ts index fb298c8c457..4f904e8a942 100644 --- a/packages/effect/test/Metric.test.ts +++ b/packages/effect/test/Metric.test.ts @@ -829,6 +829,17 @@ describe("Metric", () => { }) describe("Summary", () => { + it.effect("rejects NaN quantiles on first use", () => + Effect.gen(function*() { + const summary = Metric.summary(nextId(), { + maxAge: "1 minute", + maxSize: 10, + quantiles: [Number.NaN] + }) + const result = yield* Effect.exit(Metric.update(summary, 1)) + assert.deepStrictEqual(result, Exit.die(new Error("Quantile must be between 0 and 1, found: NaN"))) + })) + it.effect("reports the maximum for negative-only observations", () => Effect.gen(function*() { const summary = Metric.summary(nextId(), {