Fix query for pg8000 driver

The following query is successful with psycopg2 driver but fails with
pg8000:

SELECT
  COUNT(a),
  b,
  CASE WHEN c IN ($1, $2) THEN true ELSE false
FROM
  my_table
GROUP BY
  b,
  CASE WHEN c IN ($3, $4) THEN true ELSE false

This fails because it is recognized as an SQL syntax error: "Column 'c'
should be aggregated by a function or should occur in the GROUP BY section".
It is there at the GROUP BY section, but the placeholders are different.
It's theoretically possible that different values will be substituted
in $1 and $3, though it will never happen. Unfortunately, SQL can't prove
this, so it results a syntax error.

Author: bruntib

web/server/codechecker_server/api/report_server.py

@@ -26,7 +26,7 @@
 
 import sqlalchemy
 from sqlalchemy.sql.expression import or_, and_, not_, func, \
-    asc, desc, union_all, select, bindparam, literal_column, case, cast, true
+    asc, desc, union_all, select, bindparam, literal_column, cast, true
 from sqlalchemy.orm import contains_eager
 from sqlalchemy.types import ARRAY, String
 
@@ -1383,48 +1383,6 @@ def get_run_id_expression(session, report_filter):
     return Run.id.label("run_id")
 
 
-def get_is_enabled_case(subquery):
-    """
-    Creating a case statement to decide the report
-    is enabled or not based on the detection status
-    """
-    detection_status_filters = subquery.c.detection_status.in_(list(
-        map(detection_status_str,
-            (DetectionStatus.OFF, DetectionStatus.UNAVAILABLE))
-    ))
-
-    return case(
-        (detection_status_filters, False),
-        else_=True
-    )
-
-
-def get_is_opened_case(subquery):
-    """
-    Creating a case statement to decide the report is opened or not
-    based on the detection status and the review status
-    """
-    detection_statuses = (
-        DetectionStatus.NEW,
-        DetectionStatus.UNRESOLVED,
-        DetectionStatus.REOPENED
-    )
-    review_statuses = (
-        API_ReviewStatus.UNREVIEWED,
-        API_ReviewStatus.CONFIRMED
-    )
-    detection_and_review_status_filters = [
-        subquery.c.detection_status.in_(list(map(
-            detection_status_str, detection_statuses))),
-        subquery.c.review_status.in_(list(map(
-            review_status_str, review_statuses)))
-    ]
-    return case(
-        (and_(*detection_and_review_status_filters), True),
-        else_=False
-    )
-
-
 def remove_reports(session: DBSession,
                    report_ids: Collection,
                    chunk_size: int = SQLITE_MAX_VARIABLE_NUMBER):
@@ -3116,18 +3074,15 @@ def getCheckerStatusVerificationDetails(self, run_ids, report_filter):
 
             subquery = subquery.subquery()
 
-            is_enabled_case = get_is_enabled_case(subquery)
-            is_opened_case = get_is_opened_case(subquery)
-
             query = (
                 session.query(
                     subquery.c.checker_id,
                     subquery.c.checker_name,
                     subquery.c.analyzer_name,
                     subquery.c.severity,
                     subquery.c.run_id,
-                    is_enabled_case.label("isEnabled"),
-                    is_opened_case.label("isOpened"),
+                    subquery.c.detection_status,
+                    subquery.c.review_status,
                     func.count(subquery.c.bug_id)
                 )
                 .group_by(
@@ -3136,8 +3091,8 @@ def getCheckerStatusVerificationDetails(self, run_ids, report_filter):
                     subquery.c.analyzer_name,
                     subquery.c.severity,
                     subquery.c.run_id,
-                    is_enabled_case,
-                    is_opened_case
+                    subquery.c.detection_status,
+                    subquery.c.review_status
                 )
             )
 
@@ -3148,8 +3103,8 @@ def getCheckerStatusVerificationDetails(self, run_ids, report_filter):
                 analyzer_name, \
                 severity, \
                 run_id_list, \
-                is_enabled, \
-                is_opened, \
+                detection_status, \
+                review_status, \
                 cnt \
                     in query.all():
 
@@ -3165,6 +3120,22 @@ def getCheckerStatusVerificationDetails(self, run_ids, report_filter):
                         outstanding=0
                     ))
 
+                is_enabled = detection_status not in map(
+                    detection_status_str,
+                    (DetectionStatus.OFF, DetectionStatus.UNAVAILABLE))
+
+                is_opened = \
+                    detection_status in map(
+                        detection_status_str,
+                        (DetectionStatus.NEW,
+                         DetectionStatus.UNRESOLVED,
+                         DetectionStatus.REOPENED)) \
+                    and \
+                    review_status in map(
+                        review_status_str,
+                        (API_ReviewStatus.UNREVIEWED,
+                         API_ReviewStatus.CONFIRMED))
+
                 if is_enabled:
                     for r in (run_id_list.split(",")
                               if isinstance(run_id_list, str)
@@ -3373,10 +3344,24 @@ def getReportStatusCounts(self, run_ids, report_filter, cmp_data):
             filter_expression, join_tables = process_report_filter(
                 session, run_ids, report_filter, cmp_data)
 
+            detection_and_review_status_filters = [
+                Report.detection_status.in_(list(map(
+                    detection_status_str,
+                    (DetectionStatus.NEW,
+                     DetectionStatus.UNRESOLVED,
+                     DetectionStatus.REOPENED)))),
+                Report.review_status.in_(list(map(
+                    review_status_str,
+                    (API_ReviewStatus.UNREVIEWED,
+                     API_ReviewStatus.CONFIRMED))))
+            ]
+
             extended_table = session.query(
                 Report.review_status,
                 Report.detection_status,
-                Report.bug_id
+                Report.bug_id,
+                and_(*detection_and_review_status_filters)
+                .label("isOutstanding")
             )
 
             if report_filter.annotations is not None:
@@ -3391,19 +3376,16 @@ def getReportStatusCounts(self, run_ids, report_filter, cmp_data):
 
             extended_table = extended_table.subquery()
 
-            is_outstanding_case = get_is_opened_case(extended_table)
-            case_label = "isOutstanding"
-
             if report_filter.isUnique:
                 q = session.query(
-                    is_outstanding_case.label(case_label),
+                    extended_table.c.isOutstanding,
                     func.count(extended_table.c.bug_id.distinct())) \
-                    .group_by(is_outstanding_case)
+                    .group_by(extended_table.c.isOutstanding)
             else:
                 q = session.query(
-                    is_outstanding_case.label(case_label),
+                    extended_table.c.isOutstanding,
                     func.count(extended_table.c.bug_id)) \
-                    .group_by(is_outstanding_case)
+                    .group_by(extended_table.c.isOutstanding)
 
             results = {
                 report_status_enum(