Improve gbak logging of ignored records with skip/include (schema) data by mentioning the table name

[mrotteveel]

Currently, looking at Firebird 5.0.4, and snapshot of 6.0.0, when using gbak with -skip_data, -include_data, -skip_schema_data or -include_schema_data on restore (i.e. the backup does include data for the tables), the gbak output mentions that records are ignored, but not the table.

For example, when using -SKIP_DATA TAB_1_%, the log output is:

gbak:restoring table "PUBLIC"."TAB_1_A"
gbak:    restoring column "ID"
gbak:restoring table "PUBLIC"."TAB_1_B"
gbak:    restoring column "ID"
gbak:restoring table "PUBLIC"."TAB_2_A"
gbak:    restoring column "ID"
gbak:restoring table "PUBLIC"."TAB_2_B"
gbak:    restoring column "ID"
gbak:committing metadata
gbak:restoring data for table "PUBLIC"."TAB_2_B"
gbak:   1 records restored
gbak:restoring data for table "PUBLIC"."TAB_2_A"
gbak:   1 records restored
gbak:     1 records ignored
gbak:     1 records ignored

The following lines are in my opinion not very helpful:

gbak:     1 records ignored
gbak:     1 records ignored

They don't mention the tables (i.e. "PUBLIC"."TAB_1_A" and "PUBLIC"."TAB_1_B"), making the log lines confusing at best.

I suggest that we change the logging to explicitly mention the table, for example like:

gbak: skipping data for table "PUBLIC"."TAB_1_A"
gbak:   1 records ignored
gbak: skipping data for table "PUBLIC"."TAB_1_B"
gbak:   1 records ignored

or, more compact:

gbak: skipped 1 records for table "PUBLIC"."TAB_1_A"
gbak: skipped 1 records for table "PUBLIC"."TAB_1_B"

Or something like 1 records ignored for table "PUBLIC"."TAB_1_A", but I think using the verb skip makes more explicit this is related to the skip/include feature.

(Also, separately, the indentation seems off for those 1 records ignored lines.)

[pavel-zotov]

I would like to ask for further improvement.
Consider script:

set list on;
set bail on;
set autoddl off;
shell if exist r:\temp\tmp4test.fdb del r:\temp\tmp4test.fdb;

create database 'localhost:r:\temp\tmp4test.fdb' user 'sysdba' password 'masterkey';
commit;

create table t_required(id int);
create table t_optional(id int);

create schema s_mandated;
create schema s_optional;

create table s_mandated.t_required(id int);
create table s_mandated.t_optional(id int);

create table s_optional.t_required(id int);
create table s_optional.t_optional(id int);
commit;

show table;

insert into t_required(id) select i from generate_series(1, 30000) as s(i);
insert into t_optional(id) select id from t_required;

insert into s_mandated.t_required(id) select id from t_required;
insert into s_mandated.t_optional(id) select id from t_required;

insert into s_optional.t_required(id) select id from t_required;
insert into s_optional.t_optional(id) select id from t_required;
commit;

After this script finish, lets make full backup and then:

1. restore with -skip_data T_OPTIONAL
2. restore all (without any "-skip")

This is difference between these restore logs:

(left part - restore log when -skip_data T_OPTIONAL was used; right part - restore all data/schema)

Now lets return to origin DB and make backup but with -skip_data T_OPTIONAL.
Difference between backup logs will be:

(left part - backup log when -skip_data T_OPTIONAL was used; right part - backup of all data/schema)

One may see that there is no explicit line aboud missed data / schema like we have in backup log:
gbak:skipping data for table "S_OPTIONAL"."T_OPTIONAL" and gbak: 30000 records ignored.

In other words, there is no any 'hint' about skipped data / schemas and we should 'guess' about them by additional comparison with full log (checked on 6.0.0.2070-d2cb23c).

Can this be added as it is now for restore ?

[aafemt]

Count of records - hardly, but skipping of tables can be logged I guess.

[AlexPeshkoff]

Count of records should not be logged. Getting it will cause read of database which we sooner of all wish to avoid using -SKIP.

[mrotteveel]

Maybe I'm misunderstanding what your asking, but if the data was left out of the backup, nothing can be logged on restore, because it's simply an empty table, just like what happens if you'd done a normal backup but the table was empty.

[pavel-zotov]

but if the data was left out of the backup, nothing can be logged on restore

IMO, the name of table which will be written in .fbk without data (because of -SKIP_* command switch) must always be logged -- both in backup and restore logs.
Currently its name is specified only in restore log.

[mrotteveel]

Maybe I'm misunderstanding what your asking, but if the data was left out of the backup, nothing can be logged on restore

This ticket is about backup counterpart of your ticket. I.e. to show names of skipped tables during backup.

OK, then I misunderstood it (BTW, this ticket is my original request).