refactor(ai-proxy): use Logger from datasource-toolkit instead of custom logger

Replace the custom Logger type with the Logger from @forestadmin/datasource-toolkit
which has the standard signature (level, message, error?). This ensures consistency
across all Forest Admin packages.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: alban bertolini

packages/agent/src/routes/ai/ai-proxy.ts

@@ -18,30 +18,20 @@ export default class AiProxyRoute extends BaseRoute {
     super(services, options);
     this.aiProxyRouter = new AiProxyRouter({
       aiClients: aiLlmConfig.aiClients,
-      logger: {
-        error: (...args: unknown[]) => {
-          this.options.logger('Error', String(args[0]));
-        },
-      },
+      logger: this.options.logger,
     });
   }
 
   setupRoutes(router: KoaRouter): void {
-    router.all('/ai-proxy/:route', this.handleAiProxy.bind(this));
+    router.post('/ai-proxy/:route', this.handleAiProxy.bind(this));
   }
 
   private async handleAiProxy(context: Context): Promise<void> {
-    const route = context.params.route as Route;
-
-    // Fetch MCP server configs from Forest Admin server
-    const mcpConfigs =
-      await this.options.forestAdminClient.mcpServerConfigService.getConfiguration();
-
     context.response.body = await this.aiProxyRouter.route({
-      route,
+      route: context.params.route,
       body: context.request.body,
-      query: context.query as { provider?: string; 'tool-name'?: string },
-      mcpConfigs,
+      query: context.query,
+      mcpConfigs: await this.options.forestAdminClient.mcpServerConfigService.getConfiguration(),
     });
     context.response.status = HttpCode.Ok;
   }

packages/ai-proxy/package.json

@@ -14,6 +14,7 @@
   "dependencies": {
     "openai": "4.95.0",
     "zod": "3.23.8",
+    "@forestadmin/datasource-toolkit": "1.50.0",
     "@langchain/community": "0.3.57",
     "@langchain/core": "0.3.78",
     "@langchain/mcp-adapters": "0.6.0"

packages/ai-proxy/src/index.ts

@@ -6,7 +6,6 @@ export * from './provider-dispatcher';
 export * from './remote-tools';
 export * from './router';
 export * from './mcp-client';
-export * from './logger';
 
 export * from './errors';
 

packages/ai-proxy/src/logger.ts

@@ -1,7 +1,8 @@
+import type { Logger } from '@forestadmin/datasource-toolkit';
+
 import { MultiServerMCPClient } from '@langchain/mcp-adapters';
 
 import { McpConnectionError } from './errors';
-import { type Logger, defaultLogger } from './logger';
 import RemoteTool from './remote-tool';
 
 export type McpConfiguration = {
@@ -10,11 +11,11 @@ export type McpConfiguration = {
 
 export default class McpClient {
   private readonly mcpClients: Record<string, MultiServerMCPClient> = {};
-  private readonly logger: Logger;
+  private readonly logger?: Logger;
 
   readonly tools: RemoteTool[] = [];
 
-  constructor(config: McpConfiguration, logger: Logger = defaultLogger) {
+  constructor(config: McpConfiguration, logger?: Logger) {
     this.logger = logger;
     // split the config into several clients to be more resilient
     // if a mcp server is down, the others will still work
@@ -43,7 +44,7 @@ export default class McpClient {
           );
           this.tools.push(...extendedTools);
         } catch (error) {
-          this.logger.error(`Error loading tools for ${name}:`, error);
+          this.logger?.('Error', `Error loading tools for ${name}`, error as Error);
           errors.push({ server: name, error: error as Error });
         }
       }),
@@ -52,7 +53,8 @@ export default class McpClient {
     // Surface partial failures to provide better feedback
     if (errors.length > 0) {
       const errorMessage = errors.map(e => `${e.server}: ${e.error.message}`).join('; ');
-      this.logger.error(
+      this.logger?.(
+        'Error',
         `Failed to load tools from ${errors.length}/${Object.keys(this.mcpClients).length} ` +
           `MCP server(s): ${errorMessage}`,
       );
@@ -75,7 +77,7 @@ export default class McpClient {
         await this.closeConnections();
       } catch (cleanupError) {
         // Log but don't throw - we don't want to mask the original connection error
-        this.logger.error('Error during test connection cleanup:', cleanupError);
+        this.logger?.('Error', 'Error during test connection cleanup', cleanupError as Error);
       }
     }
   }
@@ -91,12 +93,14 @@ export default class McpClient {
 
     if (failures.length > 0) {
       failures.forEach(({ name, result }) => {
-        this.logger.error(
-          `Failed to close MCP connection for ${name}:`,
+        this.logger?.(
+          'Error',
+          `Failed to close MCP connection for ${name}`,
           (result as PromiseRejectedResult).reason,
         );
       });
-      this.logger.error(
+      this.logger?.(
+        'Error',
         `Failed to close ${failures.length}/${results.length} MCP connections. ` +
           `This may result in resource leaks.`,
       );

packages/ai-proxy/src/mcp-client.ts

@@ -1,9 +1,10 @@
+import type { Logger } from '@forestadmin/datasource-toolkit';
+
 import type { McpConfiguration } from './mcp-client';
 import type { Clients, DispatchBody } from './provider-dispatcher';
 import type { Messages, RemoteToolsApiKeys } from './remote-tools';
 
 import { AIUnprocessableError, ProviderDispatcher } from './index';
-import { type Logger, defaultLogger } from './logger';
 import McpClient from './mcp-client';
 import { RemoteTools } from './remote-tools';
 
@@ -19,12 +20,12 @@ export type ApiKeys = RemoteToolsApiKeys;
 export class Router {
   private readonly localToolsApiKeys?: ApiKeys;
   private readonly aiClients: Clients;
-  private readonly logger: Logger;
+  private readonly logger?: Logger;
 
   constructor(params?: { aiClients: Clients; localToolsApiKeys?: ApiKeys; logger?: Logger }) {
     this.aiClients = params?.aiClients;
     this.localToolsApiKeys = params?.localToolsApiKeys;
-    this.logger = params?.logger ?? defaultLogger;
+    this.logger = params?.logger;
   }
 
   /**
@@ -90,7 +91,7 @@ export class Router {
         try {
           await mcpClient.closeConnections();
         } catch (cleanupError) {
-          this.logger.error('Error during MCP connection cleanup:', cleanupError);
+          this.logger?.('Error', 'Error during MCP connection cleanup', cleanupError as Error);
         }
       }
     }