Skip to content

GT Potion code is registering a duplicate minecraft:water #4733

@Mqrius

Description

@Mqrius

Checked for existing issues

  • I have checked for existing issues, and have found none.

Tested latest version

  • I have checked that this occurs on the latest version.

GregTech CEu Version

7.5.2

Minecraft Version

1.20.1 Forge

Recipe Viewer Installed

Any

Environment

Singleplayer

Cross-Mod Interaction

No

Other Installed Mods

TFG

Actual Behavior

In GTEMIPlugin, GT registers a fluid for all potion types:

        for (Potion potion : BuiltInRegistries.POTION) {
            FluidStack stack = PotionFluidHelper.getFluidFromPotion(potion, PotionFluidHelper.BOTTLE_AMOUNT);
            registry.addEmiStack(EmiStack.of(stack.getFluid(), stack.getTag()));
        }

One of the potion types is the water potion.

This causes GT to register a second minecraft:water in the registry.

Image Image

Additional Information

Besides GTEMIPlugin, there's similar code in GTREIPlugin and GTJEIPlugin. Which runs depends on which recipe viewer is loaded.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions