Add tests for GeoInterface.coordtype and fix method ambiguity - #274
Merged
Merged
Conversation
Add comprehensive tests for coordtype covering Point, Line, LineString, Polygon, MultiPoint, MultiLineString, MultiPolygon, Triangle, and Mesh types with different coordinate types (Int, Float32, Float64). Fix method ambiguity in coordtype implementation by using specific GeoInterface traits instead of AbstractGeometryTrait, avoiding conflicts with GeoInterface's fallback methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
This one seems mergeable to me, I'll go over the others in the next few days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeoInterface.coordtypecovering all geometry types: Point, Line, LineString, Polygon, MultiPoint, MultiLineString, MultiPolygon, Triangle (Ngon), and MeshAbstractGeometryTrait, which was conflicting with GeoInterface's fallback methodsTest plan
🤖 Generated with Claude Code