I'm a bit confused about how new entries are being created in EntryService.CreateAsync:
_encrypter.GetSalt(randomSecureKey) is called to generate a salt - but the parameter randomSecureKey is never actually used by GetSalt
var randomSecureKey = _encrypter.GetRandomSecureKey(); is called to generate a random encryption key, but this key is only used in the call to GetSalt mentioned in (1)
I guess this is just a hangover from some refactoring, but thought it worth mentioning.
I'm a bit confused about how new entries are being created in
EntryService.CreateAsync:_encrypter.GetSalt(randomSecureKey)is called to generate a salt - but the parameterrandomSecureKeyis never actually used byGetSaltvar randomSecureKey = _encrypter.GetRandomSecureKey();is called to generate a random encryption key, but this key is only used in the call toGetSaltmentioned in (1)I guess this is just a hangover from some refactoring, but thought it worth mentioning.