fix(bootstrap): increase namespace wait timeout to ~180s#434
Closed
riyadhctg wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(bootstrap): increase namespace wait timeout to ~180s#434riyadhctg wants to merge 1 commit intoNVIDIA:mainfrom
riyadhctg wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The 60-attempt (~120s) timeout in wait_for_namespace() is insufficient on first run when K3s images need to be pulled and initialized. This causes the CLI to exit before reaching PKI generation, leaving the cluster without TLS secrets. Increase attempts from 60 to 90 (~180s) to accommodate slower machines and first-run scenarios. Fixes part of NVIDIA#433
|
Thank you for your interest in contributing to OpenShell, @riyadhctg. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Author
|
I have read the DCO document and I hereby sign the DCO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increases the
wait_for_namespace()timeout from ~120s to ~180s to preventbootstrap failures on first run when K3s needs extra time to pull images and
initialize.
Related Issue
Fixes part of #143
Changes
attemptsfrom 60 to 90 inwait_for_namespace()(
crates/openshell-bootstrap/src/lib.rs)Testing
mise run pre-commitpassesRAM) where it previously timed out
Checklist