Merge pull request #23 from Open-NET-Libraries/feature/10.1-phase1

Phase 1: TFM & compatibility foundation (10.1.0)

Author: electricessence

Source/Core/Compatibility/OverloadResolutionPriorityAttribute.cs

@@ -0,0 +1,22 @@
+#if !NET10_0_OR_GREATER
+// Polyfill for System.Runtime.CompilerServices.OverloadResolutionPriorityAttribute.
+// The attribute ships in-box on .NET 9+, but net10.0 is this library's modern target, so
+// everything below it (the netstandard shims and net472) gets this internal definition.
+// The C# 13+ compiler recognizes it by full metadata name and honors a source-defined copy,
+// decoding the priority from the attribute blob without requiring the type to be public or
+// from the runtime. Verified on netstandard2.0 both in-assembly (the ns2.0 compiler honors it)
+// and cross-assembly (a net10 consumer honors this internal attribute read from ns2.0 metadata),
+// with a no-attribute negative control confirming causation. This is what lets the modern span
+// overloads added during API modernization win overload resolution uniformly across every TFM.
+namespace System.Runtime.CompilerServices;
+
+[AttributeUsage(
+	AttributeTargets.Method | AttributeTargets.Constructor | AttributeTargets.Property,
+	AllowMultiple = false,
+	Inherited = false)]
+internal sealed class OverloadResolutionPriorityAttribute(int priority) : Attribute
+{
+	/// <summary>The priority of the target within its overload set.</summary>
+	public int Priority { get; } = priority;
+}
+#endif

Source/Core/ExpressiveDbCommandBase.cs

@@ -217,7 +217,7 @@ public ValueTask<IEnumerable<T0>> FirstOrdinalResultsAsync<T0>()
 	/// <param name="n">The first ordinal to include in the request to the reader for each record.</param>
 	/// <param name="others">The remaining ordinals to request from the reader for each record.</param>
 	/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
-#if NET8_0_OR_GREATER
+#if NET10_0_OR_GREATER
 	public ValueTask<QueryResultQueue<object[]>> RetrieveAsync(int n, params IEnumerable<int> others)
 		=> RetrieveAsync(others.Prepend(n));
 #else
@@ -231,7 +231,7 @@ public ValueTask<QueryResultQueue<object[]>> RetrieveAsync(int n, params int[] o
 	/// <param name="c">The first column name to include in the request to the reader for each record.</param>
 	/// <param name="others">The remaining column names to request from the reader for each record.</param>
 	/// <returns>The QueryResult that contains all the results and the column mappings.</returns>
-#if NET8_0_OR_GREATER
+#if NET10_0_OR_GREATER
 	public ValueTask<QueryResultQueue<object[]>> RetrieveAsync(string c, params IEnumerable<string> others)
 		=> RetrieveAsync(others.Prepend(c));
 #else

Source/Core/Extensions/DataReader.cs

@@ -277,7 +277,7 @@ public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, IEnume
 	/// <param name="n">The first ordinal to include in the request to the reader for each record.</param>
 	/// <param name="others">The remaining ordinals to request from the reader for each record.</param>
 	/// <inheritdoc cref="AsEnumerable(IDataReader, ArrayPool{object?}, int, int[])"/>
-#if NET8_0_OR_GREATER
+#if NET10_0_OR_GREATER
 	public static IEnumerable<object[]> AsEnumerable(this IDataReader reader, int n, params IEnumerable<int> others)
 		=> AsEnumerableInternal(reader, others.Prepend(n), false);
 #else

Source/Core/Extensions/_.cs

@@ -126,7 +126,7 @@ internal static IEnumerable<T> Concat<T>(T first, ICollection<T> remaining)
 		if (values is null) throw new ArgumentNullException(nameof(values));
 		Contract.EndContractBlock();
 
-#if NET8_0_OR_GREATER
+#if NET10_0_OR_GREATER
 		var span = System.Runtime.InteropServices.CollectionsMarshal.AsSpan(values);
 		for (int i = 0; i < span.Length; i++)
 		{
@@ -187,7 +187,7 @@ static IEnumerable<DataRow> AsEnumerableCore(DataRowCollection rows)
 		.Results(table, clearSourceTable);
 
 	/// <inheritdoc cref="To{T}(DataTable, IEnumerable{KeyValuePair{string, string?}}?, bool)"/>
-#if NET8_0_OR_GREATER
+#if NET10_0_OR_GREATER
 	public static IEnumerable<T> To<T>(this DataTable table, params IEnumerable<(string Field, string? Column)> fieldMappingOverrides) where T : new()
 #else
 	public static IEnumerable<T> To<T>(this DataTable table, params (string Field, string? Column)[] fieldMappingOverrides) where T : new()

Source/Directory.Build.props

@@ -3,10 +3,15 @@
 	<PropertyGroup>
 		<RootNamespace>Open.Database.Extensions</RootNamespace>
 
+		<!-- Stays at 10.0.1 through the phase stack; bumped to 10.1.0 only in the final release phase. -->
 		<VersionPrefix>10.0.1</VersionPrefix>
 		<VersionSuffix Condition="'$(Configuration)' == 'Debug'">debug</VersionSuffix>
-		
-		<TargetFrameworks>netstandard2.0; netstandard2.1; net8.0; net10.0;</TargetFrameworks>
+
+		<!-- net10.0 is the primary/modern target. netstandard2.0/2.1 are retained as shimmed
+		     legacy paths (via #if switching + BCL compat packages). net472 lives only on the
+		     MSSqlClient adapter; .NET Framework consumers of the other packages use the
+		     netstandard2.0 build. net8/net9 consumers fall back to netstandard2.1. -->
+		<TargetFrameworks>netstandard2.0; netstandard2.1; net10.0;</TargetFrameworks>
 		<LangVersion>latest</LangVersion>
 		<Nullable>enable</Nullable>
 		<ImplicitUsings>true</ImplicitUsings>

Source/MSSqlClient/Extensions/Transaction.cs

@@ -60,7 +60,7 @@ public static (bool Commit, T Value) ExecuteTransactionConditional<T>(
 		if (connection.State != ConnectionState.Open)
 			await connection.EnsureOpenAsync(cancellationToken);
 
-#if NET8_0_OR_GREATER
+#if NET10_0_OR_GREATER
 		await
 #endif
 		using SqlTransaction transaction = connection.BeginTransaction(isolationLevel);

Source/MSSqlClient/Open.Database.Extensions.MSSqlClient.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
-		<TargetFrameworks>net472; net8.0; net10.0;</TargetFrameworks>
+		<TargetFrameworks>net472; net10.0;</TargetFrameworks>
 		<Description>Useful set of utilities and abstractions for simplifying modern SQL Client data-access operations and ensuring DI compatibility.</Description>
 		<PackageTags>ado;ado extensions;sql;connection factory;extensions;</PackageTags>
 	</PropertyGroup>

Source/SqlClient/Extensions/Transaction.cs

@@ -60,7 +60,7 @@ public static (bool Commit, T Value) ExecuteTransactionConditional<T>(
 		if (connection.State != ConnectionState.Open)
 			await connection.EnsureOpenAsync(cancellationToken);
 
-#if NET8_0_OR_GREATER
+#if NET10_0_OR_GREATER
 		await
 #endif
 		using SqlTransaction transaction = connection.BeginTransaction(isolationLevel);