From 312cfce27a30fb78a4122375ae6f2ee730547e4c Mon Sep 17 00:00:00 2001 From: szlt5 <117269245+szlt5@users.noreply.github.com> Date: Tue, 8 Sep 2026 16:49:04 +0800 Subject: [PATCH 1/2] Fix minor errors; this caused issue #239. --- cupsfilters/ipp-options.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cupsfilters/ipp-options.c b/cupsfilters/ipp-options.c index 27f0a3918..c66524d1a 100644 --- a/cupsfilters/ipp-options.c +++ b/cupsfilters/ipp-options.c @@ -404,7 +404,7 @@ cfFilterOptionsCreate(size_t num_options, // I - Number of command-line option ippo->separator_media = ippo->media; // Set the rest of the options... - if ((value = get_option("output-order", num_options, options)) != NULL) + if ((value = get_option("outputorder", num_options, options)) != NULL) { if (!strcasecmp(value, "reverse")) ippo->reverse_order = true; @@ -492,9 +492,9 @@ cfFilterOptionsCreate(size_t num_options, // I - Number of command-line option if ((value = get_option("imposition-template", num_options, options)) != NULL || (value = get_option("booklet", num_options, options)) != NULL) { - if(strcasecmp(value, "yes") || - strcasecmp(value, "true") || - strcasecmp(value, "booklet")) + if(!strcasecmp(value, "yes") || + !strcasecmp(value, "true") || + !strcasecmp(value, "booklet")) { cupsCopyString(ippo->imposition_template, "booklet", sizeof(ippo->imposition_template)); } From 4c1fd1ae73b50faec17ace284f534595f3c6742c Mon Sep 17 00:00:00 2001 From: szlt5 <117269245+szlt5@users.noreply.github.com> Date: Tue, 8 Sep 2026 17:09:42 +0800 Subject: [PATCH 2/2] Fix issue 239 --- cupsfilters/ipp-options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cupsfilters/ipp-options.c b/cupsfilters/ipp-options.c index c66524d1a..0b057dcd4 100644 --- a/cupsfilters/ipp-options.c +++ b/cupsfilters/ipp-options.c @@ -404,7 +404,8 @@ cfFilterOptionsCreate(size_t num_options, // I - Number of command-line option ippo->separator_media = ippo->media; // Set the rest of the options... - if ((value = get_option("outputorder", num_options, options)) != NULL) + if ((value = get_option("outputorder", num_options, options)) != NULL || + (value = cupsGetOption("output-order", num_options, options)) != NULL) { if (!strcasecmp(value, "reverse")) ippo->reverse_order = true;