You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Every packet write goes through Serializer.createPacketBuffer, but a compiled protocol never sets e.field, so the errors coming out say nothing about which packet failed:
Error: Write error for undefined : Missing field 'x'
Error: SizeOf error for undefined : 0 is not in the mappings value
The interpreter names it through the switch's field path (params.position.face); the compiler reports no path at all. The error is thrown inside _transform and surfaces asynchronously on the stream, so a caller cannot attribute it after the fact either.
Change
Serializer.createPacketBuffer prefixes the message with in packet <name>: when the value has a name and the error's field path does not already contain it:
in packet position: SizeOf error for undefined : up is not in the mappings value
Interpreted errors and values without a name are untouched.
Testing
New tests in test/misc.js: compiled gets the prefix, interpreted keeps its field path with no duplicate, a value with no name is left alone.
Every packet write goes through Serializer.createPacketBuffer, but a compiled protocol never sets e.field, so the errors coming out say nothing about which packet failed:
Nice, this is the packet-level half of the problem. I have a complementary branch that fills in the other half: it threads e.field through the compiled container read/write/sizeOf codegen (mirroring the interpreted tryDoc), so a compiled protocol produces a real dotted field path instead of undefined - e.g. SizeOf error for meta.label rather than SizeOf error for undefined. It stacks cleanly with this PR (your in packet <name>: prefix plus a populated field path -> in packet position: SizeOf error for meta.label), and it's what surfaces which field of a bedrock packet is missing/wrong (the recurring "bad_packet / SizeOf undefined" reports). Happy to open it as a follow-up on top of this once it lands, or fold it in here if you'd prefer. Verified with a nested round-trip matching the interpreted path exactly, full suite green + a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every packet write goes through
Serializer.createPacketBuffer, but a compiled protocol never setse.field, so the errors coming out say nothing about which packet failed:The interpreter names it through the switch's field path (
params.position.face); the compiler reports no path at all. The error is thrown inside_transformand surfaces asynchronously on the stream, so a caller cannot attribute it after the fact either.Change
Serializer.createPacketBufferprefixes the message within packet <name>:when the value has anameand the error's field path does not already contain it:Interpreted errors and values without a
nameare untouched.Testing
test/misc.js: compiled gets the prefix, interpreted keeps its field path with no duplicate, a value with nonameis left alone.npm test: lint clean, 504 passing.