Skip to content

Commit 0f13faa

Browse files
committed
2 parents eb378d8 + af41a3f commit 0f13faa

6 files changed

Lines changed: 5 additions & 7 deletions

File tree

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ local.properties
5050
*.meta
5151
*.obj
5252
*.pch
53-
*.pdb
53+
#*.pdb
5454
*.pgc
5555
*.pgd
5656
*.rsp

Rally.RestApi.Test/SSOHelperTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ public void ParseSSOTokenPage()
8080
Assert.AreEqual(cookie.Value, "khkjhkhkhkhkjhh");
8181
Assert.AreEqual(cookie.Domain, "us1.rallydev.com");
8282
Assert.AreEqual(cookie.Path, "/");
83-
Assert.IsTrue(cookie.Secure);
8483
}
8584

8685
private String getDataFromFile(String filename)

Rally.RestApi.Test/data/SSOTokenPage.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<input type="hidden" name="authCookieValue" value="khkjhkhkhkhkjhh"/>
1010
<input type="hidden" name="authCookieDomain" value="us1.rallydev.com"/>
1111
<input type="hidden" name="authCookiePath" value="/"/>
12-
<input type="hidden" name="authCookieSecure" value="true"/>
1312
</form>
1413
</body>
1514
</html>

Rally.RestApi/SSOHelper.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -421,12 +421,12 @@ public static Cookie parsSSOLandingPage(String htmlPage)
421421
authCookie.Value = inputNode.GetAttributeValue("value", "");
422422
continue;
423423
case "authCookieDomain":
424-
authCookie.Domain = "";
425-
//authCookie.Domain = inputNode.GetAttributeValue("value", "");
424+
String domain = inputNode.GetAttributeValue("value", "");
425+
authCookie.Domain = domain == null || domain == "null" ? "" : domain;
426426
continue;
427427
case "authCookiePath":
428-
authCookie.Path = "";
429-
//authCookie.Path = inputNode.GetAttributeValue("value", "");
428+
String path = inputNode.GetAttributeValue("value", "");
429+
authCookie.Path = path == null || path == "null" ? "" : path;
430430
continue;
431431
}
432432
}
132 KB
Binary file not shown.
266 KB
Binary file not shown.

0 commit comments

Comments
 (0)