Using a correct time in log file#730
Merged
tridge merged 2 commits intoRsyncProject:masterfrom Apr 22, 2026
Merged
Conversation
Contributor
Author
|
Not entirely sure whether this is related but I saw the same fail on i686 in Fedora (other arches were fine) - https://kojipkgs.fedoraproject.org//work/tasks/1350/128681350/build.log |
Contributor
|
@mruprich Link above is "not found" for me |
Contributor
Author
|
Hi @elboulangero which link are you reffering to? |
Contributor
Contributor
Author
|
Aaah, right, the scratch build in Fedora is empty after a while. I tried a new one and seems like that was some temporary error - https://koji.fedoraproject.org/koji/taskinfo?taskID=129850493. Is there a way restart the failed test here in the PR? |
Contributor
Author
|
Hi, the checks passed after the last rebase. Any update? Anything that should be changed in the PR? |
Contributor
Author
|
Hi, any update with this PR? |
localtime/localtime_r need /etc/localtime for timezone info. After chroot this file is inaccessible, causing log timestamps to fall back to UTC. Calling tzset() before chroot ensures the timezone data is cached by glibc for subsequent calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
@mruprich thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #729. Log after the fix:
Credit for the fix goes to https://github.com/remicollet