Follow-up from #949 (toolchain migration to oxc + TypeScript 7 + vite 8).
To build the library packages under vite 8 + vite-plugin-dts 5.x, #949 carries a local pnpm patch of @tanstack/vite-config@0.5.2:
patches/@tanstack__vite-config@0.5.2.patch
dts({ outDir }) → dts({ outDirs }) — vite-plugin-dts 5.x renamed the option; the 4.x outDir is silently ignored.
- adds
rollupOptions: { output: { preserveModules: true } } alongside rolldownOptions so module preservation holds under vite 8's rollup path.
0.5.2 is the latest published @tanstack/vite-config, so there is no upstream release to bump to. The patch is a stopgap.
Task
- Open a PR against
TanStack/config making @tanstack/vite-config compatible with vite-plugin-dts 5.x / vite 8 (the two changes above, guarded appropriately for the dts version it ships).
- Once released, bump
@tanstack/vite-config here and delete the patch:
- remove
patches/@tanstack__vite-config@0.5.2.patch
- remove the
patchedDependencies entry in pnpm-workspace.yaml
- re-run
pnpm install and the build to confirm parity.
Raised by @tombeckenham in review of #949 ("I don't love the patch to the tanstack config... Can we fix upstream?").
Follow-up from #949 (toolchain migration to oxc + TypeScript 7 + vite 8).
To build the library packages under vite 8 + vite-plugin-dts 5.x, #949 carries a local pnpm patch of
@tanstack/vite-config@0.5.2:patches/@tanstack__vite-config@0.5.2.patchdts({ outDir })→dts({ outDirs })— vite-plugin-dts 5.x renamed the option; the 4.xoutDiris silently ignored.rollupOptions: { output: { preserveModules: true } }alongsiderolldownOptionsso module preservation holds under vite 8's rollup path.0.5.2is the latest published@tanstack/vite-config, so there is no upstream release to bump to. The patch is a stopgap.Task
TanStack/configmaking@tanstack/vite-configcompatible with vite-plugin-dts 5.x / vite 8 (the two changes above, guarded appropriately for the dts version it ships).@tanstack/vite-confighere and delete the patch:patches/@tanstack__vite-config@0.5.2.patchpatchedDependenciesentry inpnpm-workspace.yamlpnpm installand the build to confirm parity.Raised by @tombeckenham in review of #949 ("I don't love the patch to the tanstack config... Can we fix upstream?").