Skip to content

Remove @tanstack/vite-config patch after fixing upstream (vite-plugin-dts 5 / vite 8) #975

Description

@AlemTuzlak

Follow-up from #949 (toolchain migration to oxc + TypeScript 7 + vite 8).

To build the library packages under vite 8 + vite-plugin-dts 5.x, #949 carries a local pnpm patch of @tanstack/vite-config@0.5.2:

patches/@tanstack__vite-config@0.5.2.patch

  • dts({ outDir })dts({ outDirs }) — vite-plugin-dts 5.x renamed the option; the 4.x outDir is silently ignored.
  • adds rollupOptions: { output: { preserveModules: true } } alongside rolldownOptions so module preservation holds under vite 8's rollup path.

0.5.2 is the latest published @tanstack/vite-config, so there is no upstream release to bump to. The patch is a stopgap.

Task

  1. Open a PR against TanStack/config making @tanstack/vite-config compatible with vite-plugin-dts 5.x / vite 8 (the two changes above, guarded appropriately for the dts version it ships).
  2. Once released, bump @tanstack/vite-config here and delete the patch:
    • remove patches/@tanstack__vite-config@0.5.2.patch
    • remove the patchedDependencies entry in pnpm-workspace.yaml
    • re-run pnpm install and the build to confirm parity.

Raised by @tombeckenham in review of #949 ("I don't love the patch to the tanstack config... Can we fix upstream?").

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions