@@ -3,6 +3,7 @@ import userEvent from "@testing-library/user-event";
33import { afterEach , beforeEach , describe , expect , it , vi } from "vitest" ;
44
55import { DialogProvider } from "@/providers/DialogProvider/DialogProvider" ;
6+ import { getProject } from "@/services/projects/projectsService" ;
67import type { Project } from "@/services/projects/types" ;
78import { useUpdateProject } from "@/services/projects/useProjects" ;
89
@@ -28,6 +29,10 @@ vi.mock("@/services/projects/useProjects", () => ({
2829 useUpdateProject : vi . fn ( ) ,
2930} ) ) ;
3031
32+ vi . mock ( "@/services/projects/projectsService" , ( ) => ( {
33+ getProject : vi . fn ( ) ,
34+ } ) ) ;
35+
3136vi . mock ( "@/hooks/useToastNotification" , ( ) => ( {
3237 default : ( ) => notify ,
3338} ) ) ;
@@ -55,10 +60,14 @@ function Subject({ subject }: { subject: Project }) {
5560 return < button onClick = { ( ) => void rename ( ) } > Rename project</ button > ;
5661}
5762
58- async function openRename ( overrides : Partial < Project > = { } ) {
63+ async function openRename (
64+ overrides : Partial < Project > = { } ,
65+ latest : Partial < Project > = overrides ,
66+ ) {
5967 vi . mocked ( useUpdateProject ) . mockReturnValue ( {
6068 mutate,
6169 } as unknown as ReturnType < typeof useUpdateProject > ) ;
70+ vi . mocked ( getProject ) . mockResolvedValue ( { ...project , ...latest } ) ;
6271
6372 const user = userEvent . setup ( ) ;
6473 render (
@@ -70,12 +79,22 @@ async function openRename(overrides: Partial<Project> = {}) {
7079 return user ;
7180}
7281
73- async function renameTo ( name : string , overrides : Partial < Project > = { } ) {
74- const user = await openRename ( overrides ) ;
75-
82+ async function submitName (
83+ user : ReturnType < typeof userEvent . setup > ,
84+ name : string ,
85+ ) {
7686 await user . clear ( screen . getByLabelText ( "Name" ) ) ;
7787 await user . type ( screen . getByLabelText ( "Name" ) , name ) ;
7888 await user . click ( screen . getByRole ( "button" , { name : "Rename" } ) ) ;
89+ }
90+
91+ async function renameTo (
92+ name : string ,
93+ overrides : Partial < Project > = { } ,
94+ latest : Partial < Project > = overrides ,
95+ ) {
96+ const user = await openRename ( overrides , latest ) ;
97+ await submitName ( user , name ) ;
7998
8099 await waitFor ( ( ) => expect ( mutate ) . toHaveBeenCalled ( ) ) ;
81100}
@@ -117,6 +136,45 @@ describe("useRenameProjectAction", () => {
117136 ) ;
118137 } ) ;
119138
139+ /** A stale copy would drop keys written since, like the shared folder id. */
140+ it ( "keeps metadata written since the project was loaded" , async ( ) => {
141+ await renameTo (
142+ "Churn model v2" ,
143+ { metadata : { provisionalName : true } } ,
144+ {
145+ metadata : { provisionalName : true , tangentSharedFolderId : "folder-1" } ,
146+ } ,
147+ ) ;
148+
149+ expect ( getProject ) . toHaveBeenCalledWith ( "project-1" ) ;
150+ expect ( mutate ) . toHaveBeenCalledWith (
151+ {
152+ id : "project-1" ,
153+ input : {
154+ name : "Churn model v2" ,
155+ metadata : { tangentSharedFolderId : "folder-1" } ,
156+ } ,
157+ } ,
158+ expect . anything ( ) ,
159+ ) ;
160+ } ) ;
161+
162+ it ( "leaves the project alone when it cannot be re-read" , async ( ) => {
163+ const consoleError = vi
164+ . spyOn ( console , "error" )
165+ . mockImplementation ( ( ) => { } ) ;
166+ const user = await openRename ( ) ;
167+ vi . mocked ( getProject ) . mockRejectedValue ( new Error ( "down" ) ) ;
168+
169+ await submitName ( user , "Churn model v2" ) ;
170+
171+ await waitFor ( ( ) =>
172+ expect ( notify ) . toHaveBeenCalledWith ( "Failed to update project" , "error" ) ,
173+ ) ;
174+ expect ( mutate ) . not . toHaveBeenCalled ( ) ;
175+ consoleError . mockRestore ( ) ;
176+ } ) ;
177+
120178 it ( "says so once the rename lands" , async ( ) => {
121179 await renameTo ( "Churn model v2" ) ;
122180
0 commit comments