report_checks crash after removing path_group

[jhkim-pii]

Describe the bug

report_checks crashed after removing path_group.

Test case: remove_path_group.tcl.zip

How to reproduce

1. Unzip the attached file in src/dbSta/test.
2. openroad remove_path_group.tcl

Crash log

...

---------------------------------------------------------
         736.73   slack (MET)


Clearing group: crash_group for module: _215_
Cleared reg2reg constraints for module: _215_
Reporting checks after clear (Suspect point)...
Signal 11 received
Stack trace:
 0# 0x00000000010061F3 in openroad
 1# 0x0000000000045330 in /lib/x86_64-linux-gnu/libc.so.6
 2# pthread_mutex_lock in /lib/x86_64-linux-gnu/libc.so.6
 3# sta::PathGroup::saveable(sta::PathEnd*) in openroad
 4# sta::MakePathEnds1::visitPathEnd(sta::PathEnd*, sta::PathGroup*) in openroad
 5# sta::MakePathEnds1::visit(sta::PathEnd*) in openroad
 6# sta::VisitPathEnds::visitCheckEnd(sta::Pin const*, sta::Vertex*, sta::Path*, sta::RiseFall const*, sta::PathAnalysisPt const*, bool, sta::PathEndVisitor*, bool&) in openroad
 7# sta::VisitPathEnds::visitClkedPathEnds(sta::Pin const*, sta::Vertex*, sta::Corner const*, sta::MinMaxAll const*, bool, sta::PathEndVisitor*, bool&) in openroad
 8# sta::VisitPathEnds::visitPathEnds(sta::Vertex*, sta::Corner const*, sta::MinMaxAll const*, bool, sta::PathEndVisitor*) in openroad
 9# sta::PathGroups::makeGroupPathEnds(sta::VertexSet*, sta::Corner const*, sta::MinMaxAll const*, sta::PathEndVisitor*) in openroad
10# sta::PathGroups::makeGroupPathEnds(sta::ExceptionTo*, int, int, bool, bool, sta::Corner const*, sta::MinMaxAll const*) in openroad
11# sta::PathGroups::makePathEnds(sta::ExceptionTo*, bool, sta::Corner const*, sta::MinMaxAll const*, bool) in openroad
12# sta::Search::findPathEnds(sta::ExceptionFrom*, sta::Vector<sta::ExceptionThru*>*, sta::ExceptionTo*, bool, sta::Corner const*, sta::MinMaxAll const*, unsigned long, unsigned long, bool, bool, float, float, bool, sta::Set<char const*, sta::CharPtrLess>*, bool, bool, bool, bool, bool, bool) in openroad
13# sta::Sta::findPathEnds(sta::ExceptionFrom*, sta::Vector<sta::ExceptionThru*>*, sta::ExceptionTo*, bool, sta::Corner const*, sta::MinMaxAll const*, int, int, bool, bool, float, float, bool, sta::Set<char const*, sta::CharPtrLess>*, bool, bool, bool, bool, bool, bool) in openroad
14# find_path_ends(sta::ExceptionFrom*, sta::Vector<sta::ExceptionThru*>*, sta::ExceptionTo*, bool, sta::Corner*, sta::MinMaxAll const*, int, int, bool, bool, float, float, bool, sta::Set<char const*, sta::CharPtrLess>*, bool, bool, bool, bool, bool, bool) in openroad
15# 0x0000000001185522 in openroad
16# TclNRRunCallbacks in /lib/x86_64-linux-gnu/libtcl8.6.so
17# 0x000000000003F6BC in /lib/x86_64-linux-gnu/libtcl8.6.so
18# Tcl_EvalEx in /lib/x86_64-linux-gnu/libtcl8.6.so
19# Tcl_Eval in /lib/x86_64-linux-gnu/libtcl8.6.so
20# sta::sourceTclFile(char const*, bool, bool, Tcl_Interp*) in openroad
21# 0x00000000010073A7 in openroad
22# Tcl_MainEx in /lib/x86_64-linux-gnu/libtcl8.6.so
23# main in openroad
24# 0x000000000002A1CA in /lib/x86_64-linux-gnu/libc.so.6
25# __libc_start_main in /lib/x86_64-linux-gnu/libc.so.6
26# _start in openroad
Segmentation fault (core dumped)

Expected Behavior

No crash

Environment

-- OpenROAD version: 26Q1-846-g9909fea941
-- System name: Linux
-- Compiler: GNU 13.3.0
-- Build type: RelWithDebInfo
-- Install prefix: /workspace/ws1/OpenROAD-flow-scripts/tools/install/OpenROAD
-- C++ Standard: 20
-- C++ Standard Required: ON
-- C++ Extensions: OFF
-- LTO/IPO is disabled
-- Performing Test C_COMPILER_SUPPORTS__-std=c++17
-- Performing Test C_COMPILER_SUPPORTS__-std=c++17 - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-std=c++17
-- Performing Test CXX_COMPILER_SUPPORTS__-std=c++17 - Success
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- TCL readline library: /usr/lib/x86_64-linux-gnu/libtclreadline.so
-- TCL readline header: /usr/include/x86_64-linux-gnu
-- Found SWIG: /usr/local/bin/swig (found suitable version "4.3.0", minimum required is "4.0")
-- Using SWIG >= 4.3.0 -flatstaticmethod flag for python
-- boost: 1.89.0
-- GTest: 1.13.0
-- spdlog: 1.15.0
-- STA version: 2.7.0
-- STA git sha: 087793e8a0c0245d0b696039c638acad425fbf66
-- System name: Linux
-- Compiler: GNU 13.3.0
-- Build type: RelWithDebInfo
-- Build CXX_FLAGS: 
-- Install prefix: /workspace/ws1/OpenROAD-flow-scripts/tools/install/OpenROAD
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- TCL readline library: /usr/lib/x86_64-linux-gnu/libtclreadline.so
-- TCL readline header: /usr/include/x86_64-linux-gnu/tclreadline.h
CMake Warning (dev) at src/sta/CMakeLists.txt:381 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  CMake variable Eigen3_ROOT is set to:

    /usr/local

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- CUDD library: /usr/local/lib/libcudd.a
-- CUDD header: /usr/local/include/cudd.h
-- SSTA: 0
CMake Warning (dev) at src/sta/CMakeLists.txt:399 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  CMake variable SWIG_ROOT is set to:

    /usr/local

  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found SWIG: /usr/local/bin/swig (found suitable version "4.3.0", minimum required is "3.0")
-- STA library: /workspace/ws1/OpenROAD-flow-scripts/tools/OpenROAD/build/libOpenSTA.a
-- STA executable: /workspace/ws1/OpenROAD-flow-scripts/tools/OpenROAD/build/sta
CMake Warning (dev) at /usr/local/share/cmake-3.31/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  Policy CMP0144 is not set: find_package uses upper-case <PACKAGENAME>_ROOT
  variables.  Run "cmake --help-policy CMP0144" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  CMake variable ABSL_ROOT is set to:

    /usr/local

  For compatibility, find_package is ignoring the variable, but code in a
  .cmake module might still use it.
Call Stack (most recent call first):
  /opt/or-tools/lib/cmake/ortools/ortoolsConfig.cmake:37 (find_dependency)
  src/gpl/CMakeLists.txt:12 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found OR-Tools: /opt/or-tools/lib/cmake/ortools (version: 9.14.6206)
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- Found OpenMP: TRUE (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- GUI is enabled
-- Could NOT find VTune (missing: VTune_LIBRARIES VTune_INCLUDE_DIRS) 
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
CMake Warning (dev) at /usr/local/share/cmake-3.31/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  Policy CMP0144 is not set: find_package uses upper-case <PACKAGENAME>_ROOT
  variables.  Run "cmake --help-policy CMP0144" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  CMake variable ABSL_ROOT is set to:

    /usr/local

  For compatibility, find_package is ignoring the variable, but code in a
  .cmake module might still use it.
Call Stack (most recent call first):
  /opt/or-tools/lib/cmake/ortools/ortoolsConfig.cmake:37 (find_dependency)
  src/mpl/CMakeLists.txt:8 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at /usr/local/share/cmake-3.31/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  Policy CMP0144 is not set: find_package uses upper-case <PACKAGENAME>_ROOT
  variables.  Run "cmake --help-policy CMP0144" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  CMake variable ABSL_ROOT is set to:

    /usr/local

  For compatibility, find_package is ignoring the variable, but code in a
  .cmake module might still use it.
Call Stack (most recent call first):
  /opt/or-tools/lib/cmake/ortools/ortoolsConfig.cmake:37 (find_dependency)
  src/par/CMakeLists.txt:18 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- TCL readline enabled
-- Tcl Extended disabled
-- Python3 enabled
-- Configuring done (1.8s)
CMake Warning at src/CMakeLists.txt:291 (add_executable):
  Cannot generate a safe runtime search path for target openroad because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so.1] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /opt/or-tools/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/gpl/test/CMakeLists.txt:67 (add_executable):
  Cannot generate a safe runtime search path for target mbff_test because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so.1] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /opt/or-tools/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/mpl/test/cpp/CMakeLists.txt:15 (add_executable):
  Cannot generate a safe runtime search path for target TestSnapper because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so.1] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /opt/or-tools/lib

  Some of these libraries may not be found correctly.

To Reproduce

Unzip the attached file.
openroad remove_path_group.tcl

Relevant log output

Screenshots

No response

Additional Context

No response

[jhkim-pii]

Running the test cased w/ OpenSTA binary does not crash.
So it may be an OpenROAD issue.

[dsengupta0628]

Fixed in Parallax/OpenSTA by jjcherry - same as my change-- So can close parallaxsw/OpenSTA@79ebc34