Strange code fragments

[j-mattsson]

1. Identical expressions on both side of the && operator:
   

   Torque3D/Engine/lib/opcode/Ice/IceLSS.h

   Line 69 in eeab0c1

   return Contains(Sphere(lss.mP0, lss.mRadius)) && Contains(Sphere(lss.mP0, lss.mRadius));

2. Strange use of comma operator in if-condition:
   

   Torque3D/Engine/source/renderInstance/renderProbeMgr.cpp

   Line 801 in eeab0c1

   if (mBRDFTexture.isValid(), probeShaderConsts->mBRDFTextureMap->getSamplerRegister() != -1)

3. Same code is executed regardless of condition:
   

   Torque3D/Engine/source/afx/xm/afxXM_Scale.cpp

   Lines 130 to 133 in eeab0c1

   	if (datablock->hasFixedWeight())
   	return new afxXM_Scale_weighted(datablock, fx);
   	else
   	return new afxXM_Scale_weighted(datablock, fx);

4. Nothing is done inside for-loop:
   

   Torque3D/Engine/source/gfx/D3D11/gfxD3D11Device.cpp

   Lines 72 to 75 in eeab0c1

   	for (U32 i = 1; i < argc; i++)
   	{
   	argv[i];
   	}

5. Enum value zero is used in bitwise AND-operation:
   

   Torque3D/Engine/source/ts/tsSortedMesh.cpp

   Line 89 in eeab0c1

   if (mPrimitives[i].matIndex & TSDrawPrimitive::Triangles)

6. bufSize (used later in a for-loop) seems to be initialized to 0 but then never changed:
   

   Torque3D/Engine/source/gfx/gl/gfxGLTextureTarget.cpp

   Line 169 in eeab0c1

   int bufsize = 0;

   
   

   Torque3D/Engine/source/gfx/gl/gfxGLTextureTarget.cpp

   Line 211 in eeab0c1

   for (int i = 0; i < bufsize; i++)

7. Looks strange to use bit mask values with logical OR-operator, perhaps bitwise OR should be used instead?
   

   Torque3D/Engine/source/T3D/gameBase/gameBase.cpp

   Line 459 in eeab0c1

   if (getTypeMask() & (PlayerObjectType || VehicleObjectType ))

[Azaezel]

1. we don't generally tweak third party libraries, but the opcode libs not really being maintained, so should be ok to drill on that one for potential fixes
2. a definite typo. should be &&
3. seems like copypasta where the rest follow this pattern:

   Torque3D/Engine/source/afx/xm/afxXM_Offset.cpp

   Lines 67 to 92 in 6e35acf

   	class afxXM_LocalOffset_weighted : public afxXM_WeightedBase
   	{
   	typedef afxXM_WeightedBase Parent;
   	Point3F local_offset;
   	public:
   	/*C*/ afxXM_LocalOffset_weighted(afxXM_LocalOffsetData*, afxEffectWrapper*);
   	virtual void updateParams(F32 dt, F32 elapsed, afxXM_Params& params);
   	};
   	//~~~~~~~~~~~~~~~~~~~~//~~~~~~~~~~~~~~~~~~~~//
   	// this fixed variation is used when
   	// the weight factors are constant.
   	class afxXM_LocalOffset_fixed : public afxXM_Base
   	{
   	typedef afxXM_Base Parent;
   	Point3F local_offset;
   	public:
   	/*C*/ afxXM_LocalOffset_fixed(afxXM_LocalOffsetData*, afxEffectWrapper*);
   	virtual void updateParams(F32 dt, F32 elapsed, afxXM_Params& params);
   	};

   . could see either stripping the check, or cooking up a (edit: non) weighted variant. that one'll take a bit more study.
4. can likely be chucked
5. ... unsure to be honest
6. I think should reference GFXGLDevice::getNumRenderTargets() given the todo-note and usage context?
7. yeah, pretty clear that one's a stray |