chore(infra): activate ORGANIZATION_LOGOS R2 binding after provisioning

Bucket usrse-organization-logos provisioned on the US-RSE Cloudflare
account (same one that hosts usrse-profile-photos), public dev URL
enabled at pub-4bc181f2e72740c08c7f842a04b43f3b.r2.dev. Uncomments the
binding in wrangler.jsonc, fills in ORGANIZATION_LOGOS_PUBLIC_URL, and
refreshes the AppEnv comment to explain why ORGANIZATION_LOGOS stays
optional (defense-in-depth for preview/test envs) instead of implying
the binding isn't provisioned yet.

The admin Branding tab and POST /admin/organizations/:id/logo endpoints
will stop returning 503 not_configured the moment the worker deploys.

Author: cdcore09

packages/api/src/types.ts

@@ -18,18 +18,17 @@ export type Bindings = {
   /** Public base URL for profile-photo bucket reads (r2.dev today). */
   PROFILE_PHOTOS_PUBLIC_URL: string;
   /**
-   * R2 bucket holding hosted organization logo files. Optional
-   * because the binding is commented out in wrangler.jsonc until the
-   * bucket is provisioned in the Cloudflare dashboard — code reading
-   * this must guard on `env.ORGANIZATION_LOGOS` being defined and
-   * fall back to the InitialsHex stamp when it isn't.
+   * R2 bucket holding hosted organization logo files. Stayed optional
+   * even though the binding is now provisioned — keeps the code
+   * defensive against preview/test environments that haven't been
+   * configured yet. Runtime gate is isLogoHostingConfigured() in
+   * lib/storage-org-logo.ts.
    */
   ORGANIZATION_LOGOS?: R2Bucket;
   /**
-   * Public base URL for organization-logo bucket reads. Empty until
-   * the bucket is provisioned and the URL is filled in via wrangler.
-   * Code that surfaces logos must treat empty-string as "not yet
-   * configured" and fall back to InitialsHex.
+   * Public base URL for organization-logo bucket reads (r2.dev URL,
+   * surfaced through wrangler.jsonc). Empty-string still means "not
+   * configured" so the gate logic stays uniform across environments.
    */
   ORGANIZATION_LOGOS_PUBLIC_URL: string;
 };

packages/api/wrangler.jsonc

@@ -17,24 +17,15 @@
     {
       "binding": "PROFILE_PHOTOS",
       "bucket_name": "usrse-profile-photos"
+    },
+    {
+      "binding": "ORGANIZATION_LOGOS",
+      "bucket_name": "usrse-organization-logos"
     }
-    // ORGANIZATION_LOGOS binding is uncommented once the bucket is
-    // provisioned in the Cloudflare dashboard. Wrangler refuses to
-    // deploy when a binding points at a bucket that doesn't exist
-    // (deploy 25594274231 failed this way), so the binding lives
-    // here as a comment until then. AppEnv.Bindings keeps the type
-    // so feature code can be written safely in the meantime.
-    // {
-    //   "binding": "ORGANIZATION_LOGOS",
-    //   "bucket_name": "usrse-organization-logos"
-    // }
   ],
   "vars": {
     "PROFILE_PHOTOS_PUBLIC_URL": "https://pub-12a8fe7ab15d4128be3f4867cc11b99f.r2.dev",
-    // Set after the bucket is provisioned. Until then, the worker
-    // shouldn't surface logos to clients — gate writes/reads on a
-    // non-empty value.
-    "ORGANIZATION_LOGOS_PUBLIC_URL": ""
+    "ORGANIZATION_LOGOS_PUBLIC_URL": "https://pub-4bc181f2e72740c08c7f842a04b43f3b.r2.dev"
   }
   // Environment variables (DATABASE_URL) are injected via:
   //   - .dev.vars   for local `wrangler dev`