Skip to content

shellcheck_test should be constrainted to work on sh_* rules #60

Description

@UebelAndre

Currently you can pass anything to data and the test will crawl sources but this can lead to unexpected behavior cross-platform with generated files. Ideally the test rule would have some targets attribute that only accepts targets with ShInfo/ShBinaryInfo (bazel-contrib/rules_shell#16) where sources can more consistently be parsed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions