diff --git a/AGENTS.md b/AGENTS.md index 0c8829d79b65a..2086b4040ad15 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -52,7 +52,7 @@ Don't spell out **Directed Acyclic Graph** except for historical context. - **Lint with ruff only:** `prek run ruff --from-ref ` - **Format with ruff only:** `prek run ruff-format --from-ref ` - **Run regular (fast) static checks:** `prek run --from-ref --stage pre-commit` -- **Run manual (slower) checks:** `prek run --from-ref --stage manual` +- **Run manual (slower) checks:** `prek run --from-ref --stage manual --skip compile-ui-assets-dev --skip view-skill-eval` (the skipped hooks start long-running local servers rather than checks that complete) - **Build docs:** `breeze build-docs` - **Determine which tests to run based on changed files:** `breeze ci selective-check --commit-ref ` @@ -294,7 +294,10 @@ code review checklist in [`.github/instructions/code-review.instructions.md`](.g described in this file. 4. Run regular (fast) static checks (`prek run --from-ref --stage pre-commit`) and fix any failures. This includes mypy checks for non-provider projects (airflow-core, task-sdk, airflow-ctl, dev, scripts, devel-common). -5. Run manual (slower) checks (`prek run --from-ref --stage manual`) and fix any failures. +5. Run manual (slower) checks + (`prek run --from-ref --stage manual --skip compile-ui-assets-dev --skip view-skill-eval`) + and fix any failures. The skipped hooks start long-running local servers rather than checks + that complete. 6. Run relevant individual tests and confirm they pass. 7. Find which tests to run for the changes with selective-checks and run those tests in parallel to confirm they pass and check for CI-specific issues. 8. Check for security issues — no secrets, no injection vulnerabilities, no unsafe patterns. diff --git a/contributing-docs/08_static_code_checks.rst b/contributing-docs/08_static_code_checks.rst index f083a957a9aea..161bd7902b881 100644 --- a/contributing-docs/08_static_code_checks.rst +++ b/contributing-docs/08_static_code_checks.rst @@ -234,7 +234,7 @@ To check other usage types of the pre-commit framework, see `Pre-commit website - "- **Lint with ruff only:** `prek run ruff --from-ref `" - "- **Format with ruff only:** `prek run ruff-format --from-ref `" - "- **Run regular (fast) static checks:** `prek run --from-ref --stage pre-commit`" - - "- **Run manual (slower) checks:** `prek run --from-ref --stage manual`" + - "- **Run manual (slower) checks:** `prek run --from-ref --stage manual --skip compile-ui-assets-dev --skip view-skill-eval` (the skipped hooks start long-running local servers rather than checks that complete)" - "- **Build docs:** `breeze build-docs`" - "- **Determine which tests to run based on changed files:** `breeze ci selective-check --commit-ref `" .. AGENT-SKILL-END diff --git a/dev/skill-evals/last-eval-hash.txt b/dev/skill-evals/last-eval-hash.txt index 8d29ed7d85ade..23452e4e6f3a0 100644 --- a/dev/skill-evals/last-eval-hash.txt +++ b/dev/skill-evals/last-eval-hash.txt @@ -1,3 +1,3 @@ # Generated by dev/skill-evals/eval.py — do not edit or resolve conflicts by hand. # Run `prek run run-skill-eval --hook-stage manual --all-files` to regenerate. -cdf346752bd43c958355d98e63453bc4a00dd82727dde4243b1c01a2e2afb5fe +725f2a0640c5b6fec7f6666484a0577dde5c87f19206b1d0bdf191a7094cd98d