Fix serial warning in starter and example archetypes#38028
Fix serial warning in starter and example archetypes#38028Subramanya-Veeregowda wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses build-time warnings related to serialization in anonymous classes within the project's starter archetypes. By explicitly suppressing these warnings, the codebase maintains cleaner logs and better IDE integration for developers using these templates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
This PR adds @SuppressWarnings("serial") to anonymous classes in both starter and example archetypes to avoid IDE warnings. Tested locally for starter module. Example archetype build requires shell environment (generate-sources.sh), so relying on CI for validation. |
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
@stankiewicz should remove it and re-commit it again or is it fine with this? |
yes please. |
|
@stankiewicz Please give review on this? |
there are conflicts -please rebase and resolve conflicts |
b90cfb5 to
5b2b417
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38028 +/- ##
============================================
+ Coverage 54.61% 57.63% +3.01%
- Complexity 1689 13344 +11655
============================================
Files 1067 2604 +1537
Lines 168155 266683 +98528
Branches 1226 10994 +9768
============================================
+ Hits 91844 153712 +61868
- Misses 74116 107183 +33067
- Partials 2195 5788 +3593
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@stankiewicz Can u go through, this i have resolved the conflict? |
|
so what is this change about after all? |
|
waiting on author |
|
@stankiewicz This change addresses the issue where starter and example archetypes show I added @SuppressWarnings("serial") to those classes so that the examples Please let me know if you'd like me to refine this further. Fixes #18120 |
|
please read your comment and your code changes. |
|
Closing since currently the code changes don't match the description (and they don't seem to add value) |
Adds @SuppressWarning("serial") to anonymous classes in starter and example archetypes to avoid serialization warnings in IDEs.
this aligns with excepted usage where DoFn and other functions are serialized.
Closes #18120
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.