Merge pull request #497 from apache/fix_get_rse

leerho · web-flow · commit adb84bf3b5a5 · 2026-03-27T12:47:40.000-07:00
fix get_RSE()
diff --git a/req/include/req_sketch_impl.hpp b/req/include/req_sketch_impl.hpp
@@ -293,7 +293,7 @@ double req_sketch<T, C, A>::get_rank_upper_bound(double rank, uint8_t num_std_de
 
 template<typename T, typename C, typename A>
 double req_sketch<T, C, A>::get_RSE(uint16_t k, double rank, bool hra, uint64_t n) {
-  return get_rank_lb(k, 2, rank, 1, n, hra);
+  return get_rank_ub(k, 2, rank, 1, n, hra) - rank;
 }
 
 template<typename T, typename C, typename A>

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,7 @@ double req_sketch<T, C, A>::get_rank_upper_bound(double rank, uint8_t num_std_de`
`293`	`293`
`294`	`294`	`template<typename T, typename C, typename A>`
`295`	`295`	`double req_sketch<T, C, A>::get_RSE(uint16_t k, double rank, bool hra, uint64_t n) {`
`296`		`- return get_rank_lb(k, 2, rank, 1, n, hra);`
	`296`	`+ return get_rank_ub(k, 2, rank, 1, n, hra) - rank;`
`297`	`297`	`}`
`298`	`298`
`299`	`299`	`template<typename T, typename C, typename A>`