Skip to content

Fix issue #3505: Set client description to identify Node.js client #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shibd wants to merge 2 commits into from
Closed

Fix issue #3505: Set client description to identify Node.js client #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db33dba
Fix issue #3505: Set client description to identify Node.js client
shibd Jan 28, 2026
1f68e4e
Fix issue #3505: Set client description to identify Node.js client
shibd Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
"include_dirs": [
"<!@(node -p \"require('node-addon-api').include\")",
],
"defines": ["NAPI_VERSION=4"],
"defines": [
"NAPI_VERSION=4",
"PULSAR_CLIENT_NODE_VERSION=\"<!(node -e \\\"require('./package.json').version\\\")\""
],
"sources": [
"src/addon.cc",
"src/Message.cc",
Expand Down
15 changes: 11 additions & 4 deletions src/Client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include <pulsar/c/client_configuration.h>
#include <pulsar/c/result.h>
#include "pulsar/ClientConfiguration.h"
#include <sstream>

static const std::string CFG_SERVICE_URL = "serviceUrl";
static const std::string CFG_AUTH = "authentication";
Expand Down Expand Up @@ -232,11 +233,17 @@ Client::Client(const Napi::CallbackInfo &info) : Napi::ObjectWrap<Client>(info)
pulsar_client_configuration_set_listener_name(cClientConfig.get(), listenerName.Utf8Value().c_str());
}

try {
this->cClient = std::shared_ptr<pulsar_client_t>(
pulsar_client_create(serviceUrl.Utf8Value().c_str(), cClientConfig.get()), pulsar_client_free);
// Set client description to identify this as a Node.js client
// Using the Node.js client version from package.json
std::ostringstream oss;
oss << "node-client-v" << PULSAR_CLIENT_NODE_VERSION;
cClientConfig.get()->conf.setDescription(oss.str());

try {
this->cClient = std::shared_ptr<pulsar_client_t>(
pulsar_client_create(serviceUrl.Utf8Value().c_str(), cClientConfig.get()), pulsar_client_free);
} catch (const std::exception &e) {
Napi::Error::New(env, e.what()).ThrowAsJavaScriptException();
Napi::Error::New(env, e.what()).ThrowAsJavaScriptException();
}
}

Expand Down
Loading