138928: only show bitstream pdf-viewer config when feature is enabled + disable feature by default

Author: bram-maegerman

src/app/pdf-viewer/pdf-viewer-enable/pdf-viewer-enable.component.ts

@@ -47,7 +47,7 @@ export class PdfViewerEnableComponent implements OnInit {
     this.isEnabled$.pipe(
       take(1),
     ).subscribe((isEnabled) => this.update(isEnabled));
-    this.isViewerConfigAllowed$ = this.pdfViewerService.viewerAllowedForBitstreamFormat$(this.dso);
+    this.isViewerConfigAllowed$ = this.pdfViewerService.viewerEnabledAndAllowedForBitstreamFormat$(this.dso);
   }
 
   update($event: boolean) {

src/app/pdf-viewer/pdf-viewer-service/pdf-viewer-service.ts

@@ -77,6 +77,20 @@ export class PdfViewerService {
     }
   }
 
+  /**
+   * Is the PDF viewer enabled and allowed for a given dspace object
+   * @param dso The dspace object to check
+   */
+  viewerEnabledAndAllowedForBitstreamFormat$(dso: DSpaceObject): Observable<boolean> {
+    if (dso instanceof Bitstream) {
+      return this.viewerAllowedForBitstreamFormat$(dso).pipe(
+        map(allowedForBsFormat => allowedForBsFormat && this.appConfig.pdfViewer.enabled),
+      );
+    } else {
+      return of(this.appConfig.pdfViewer.enabled);
+    }
+  }
+
   /**
    * Is the viewer enabled for this dspace object
    * @param dsoToCheck  The dspace object to check

src/config/default-app-config.ts

@@ -652,6 +652,6 @@ export class DefaultAppConfig implements AppConfig {
 
   // PDF viewer configuration, used by the PdfViewerService
   pdfViewer: PdfViewerConfig = {
-    enabled: true,
+    enabled: false,
   };
 }