feat: add EIP-8130 ITransactionContext and INonceManager interfaces#148
Open
chunter-cb wants to merge 2 commits into
Open
feat: add EIP-8130 ITransactionContext and INonceManager interfaces#148chunter-cb wants to merge 2 commits into
chunter-cb wants to merge 2 commits into
Conversation
Add Solidity interfaces for the two EIP-8130 system precompiles and wire them into StdPrecompiles, aligned with the latest EIP-8130 spec naming: - ITransactionContext: resolved sender / payer / sender actor id of the in-flight EIP-8130 account-abstraction transaction (getTransactionSender, getTransactionPayer, getTransactionSenderActorId). Zero values outside an EIP-8130 transaction. - INonceManager: 2D nonce manager (getNonce(account, nonceKey)) enabling concurrent AA execution, plus the NonceIncremented event and revert errors. Addresses match the EIP-8130 constant table: NONCE_MANAGER_ADDRESS = 0x8130..aa01, TX_CONTEXT_ADDRESS = 0x8130..aa02. Co-authored-by: Cursor <cursoragent@cursor.com>
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟢 B20FactoryLib.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.95% | 99.08% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockPolicyRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 99.86% | 99.88% | 100.00% | 100.00% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
✅ Fork tests: all 602 passedbase/base is fully in sync with the base-std spec. |
Correct the NatSpec: on non-EIP-8130 transactions the transaction-context precompile is not populated and the getters fall back to tx.origin rather than the zero value. getTransactionSender / getTransactionPayer return tx.origin and getTransactionSenderActorId returns bytes32(bytes20(tx.origin)).
chunter-cb
requested review from
amiecorso,
eric-ships,
ilikesymmetry,
rayyan224 and
stevieraykatz
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Solidity interfaces for the two EIP-8130 system precompiles and wire them into
StdPrecompiles, aligned with the latest EIP-8130 spec naming.ITransactionContext: resolved sender / payer / sender actor id of the in-flight EIP-8130 account-abstraction transaction (getTransactionSender,getTransactionPayer,getTransactionSenderActorId). Zero values outside an EIP-8130 transaction.INonceManager: 2D nonce manager (getNonce(account, nonceKey)) enabling concurrent AA execution, plus theNonceIncrementedevent and revert errors.Addresses match the EIP-8130 constant table:
NONCE_MANAGER_ADDRESS = 0x8130..aa01,TX_CONTEXT_ADDRESS = 0x8130..aa02.Test plan
forge buildforge fmt --check