Skip to content

Commit b786950

Browse files
committed
Address review
1 parent de09afd commit b786950

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎dll/cpl/desk/effappdlg.c‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ do { \
4949
/* Large icons */
5050
state = SendDlgItemMessageW(hwndDlg, IDC_EFFAPPEARANCE_LARGEICONS, BM_GETCHECK, 0, 0);
5151
g->SchemeAdv.iIconSize = (state == BST_UNCHECKED ? NORMAL_ICON_SIZE :
52-
(state == BST_CHECKED ? LARGE_ICON_SIZE : g_CustomIconSize));
52+
(state == BST_CHECKED ? LARGE_ICON_SIZE : g_CustomIconSize));
5353

5454
/* Other checkboxes */
5555
SAVE_CHECKBOX(IDC_EFFAPPEARANCE_SETDROPSHADOW, bDropShadow);
@@ -123,9 +123,13 @@ do { \
123123

124124
/* Large icons */
125125
if (g->SchemeAdv.iIconSize == NORMAL_ICON_SIZE)
126+
{
126127
state = BST_UNCHECKED;
128+
}
127129
else if (g->SchemeAdv.iIconSize == LARGE_ICON_SIZE)
130+
{
128131
state = BST_CHECKED;
132+
}
129133
else
130134
{
131135
state = BST_INDETERMINATE;

‎dll/cpl/desk/theme.c‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ ApplyScheme(IN COLOR_SCHEME *scheme, IN PTHEME_SELECTION pSelectedTheme)
361361
RegCloseKey(hKey);
362362
}
363363

364-
/* Write the icon size to registry */
364+
/* Save the icon size to registry */
365365
Result = RegCreateKeyW(HKEY_CURRENT_USER, g_CPMetrics, &hKey);
366366
if (Result == ERROR_SUCCESS)
367367
{
@@ -414,9 +414,6 @@ ApplyScheme(IN COLOR_SCHEME *scheme, IN PTHEME_SELECTION pSelectedTheme)
414414
*/
415415
InvalidateRect(NULL, NULL, TRUE);
416416

417-
/* Use large icons */
418-
//SYS_CONFIG(SPI_GETDRAGFULLWINDOWS, (PVOID) g->SchemeAdv.Effects.bMenuFade);
419-
420417
/* Show shadows under windows */
421418
SYS_CONFIG(SPI_SETDROPSHADOW, 0, IntToPtr(scheme->Effects.bDropShadow));
422419

0 commit comments

Comments
 (0)