-
Notifications
You must be signed in to change notification settings - Fork 2
Add proparty-base tests for transcoder and MVCC store #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6a1f596
Add fuzz tests for transcoder and MVCC store
bootjp 105937e
Replace fuzz tests with property-based tests
bootjp b0e9ff2
Refactor tests with testify require package
bootjp 53726d2
Add StartTS equality checks to transcoder tests
bootjp 9b770a5
Refactor to use reusable non-empty filters
bootjp d680ab5
Add applyOps function for memory operations
bootjp beb4cfa
Fix spacing in applyOps function signature
bootjp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package adapter | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "testing" | ||
|
|
||
| "github.com/bootjp/elastickv/kv" | ||
| "github.com/stretchr/testify/require" | ||
| "pgregory.net/rapid" | ||
| ) | ||
|
|
||
| var nonEmptyString = rapid.String().Filter(func(s string) bool { return s != "" }) | ||
|
|
||
| func TestDynamoDBTranscoder_Property_PutItem(t *testing.T) { | ||
| rapid.Check(t, func(t *rapid.T) { | ||
| tableName := rapid.String().Draw(t, "tableName") | ||
| key := nonEmptyString.Draw(t, "key") | ||
| value := nonEmptyString.Draw(t, "value") | ||
| tr := newDynamoDBTranscoder() | ||
|
|
||
| input := putItemInput{ | ||
| TableName: tableName, | ||
| Item: map[string]attributeValue{ | ||
| "key": {S: key}, | ||
| "value": {S: value}, | ||
| }, | ||
| } | ||
|
|
||
| b, err := json.Marshal(input) | ||
| require.NoError(t, err) | ||
|
|
||
| got, err := tr.PutItemToRequest(b) | ||
| require.NoError(t, err) | ||
| require.Len(t, got.Elems, 1) | ||
| require.Equal(t, kv.Put, got.Elems[0].Op) | ||
| require.Equal(t, key, string(got.Elems[0].Key)) | ||
| require.Equal(t, value, string(got.Elems[0].Value)) | ||
| }) | ||
| } | ||
|
|
||
| func TestDynamoDBTranscoder_Property_TransactWrite(t *testing.T) { | ||
| rapid.Check(t, func(t *rapid.T) { | ||
| tr := newDynamoDBTranscoder() | ||
| k1 := nonEmptyString.Draw(t, "k1") | ||
| v1 := nonEmptyString.Draw(t, "v1") | ||
| k2 := nonEmptyString.Draw(t, "k2") | ||
| v2 := nonEmptyString.Draw(t, "v2") | ||
|
|
||
| txInput := transactWriteItemsInput{ | ||
| TransactItems: []transactWriteItem{ | ||
| {Put: &putItemInput{Item: map[string]attributeValue{"key": {S: k1}, "value": {S: v1}}}}, | ||
| {Put: &putItemInput{Item: map[string]attributeValue{"key": {S: k2}, "value": {S: v2}}}}, | ||
| }, | ||
| } | ||
|
|
||
| bTx, err := json.Marshal(txInput) | ||
| require.NoError(t, err) | ||
|
|
||
| gotTx, err := tr.TransactWriteItemsToRequest(bTx) | ||
| require.NoError(t, err) | ||
| require.True(t, gotTx.IsTxn) | ||
| require.Equal(t, uint64(0), gotTx.StartTS) | ||
| require.Len(t, gotTx.Elems, 2) | ||
|
|
||
| require.Equal(t, kv.Put, gotTx.Elems[0].Op) | ||
| require.Equal(t, k1, string(gotTx.Elems[0].Key)) | ||
| require.Equal(t, v1, string(gotTx.Elems[0].Value)) | ||
| require.Equal(t, kv.Put, gotTx.Elems[1].Op) | ||
| require.Equal(t, k2, string(gotTx.Elems[1].Key)) | ||
| require.Equal(t, v2, string(gotTx.Elems[1].Value)) | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| package adapter | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "testing" | ||
|
|
||
| "github.com/bootjp/elastickv/kv" | ||
| pb "github.com/bootjp/elastickv/proto" | ||
| "github.com/stretchr/testify/require" | ||
| "pgregory.net/rapid" | ||
| ) | ||
|
|
||
| func TestGrpcTranscoder_Property_RawPut(t *testing.T) { | ||
| rapid.Check(t, func(t *rapid.T) { | ||
| key := rapid.SliceOf(rapid.Byte()).Draw(t, "key") | ||
| value := rapid.SliceOf(rapid.Byte()).Draw(t, "value") | ||
| tr := newGrpcGrpcTranscoder() | ||
|
|
||
| putReq := &pb.RawPutRequest{Key: key, Value: value} | ||
| gotPut, err := tr.RawPutToRequest(putReq) | ||
| require.NoError(t, err) | ||
| require.False(t, gotPut.IsTxn) | ||
| require.Len(t, gotPut.Elems, 1) | ||
| require.Equal(t, kv.Put, gotPut.Elems[0].Op) | ||
| require.Equal(t, key, gotPut.Elems[0].Key) | ||
| require.Equal(t, value, gotPut.Elems[0].Value) | ||
|
|
||
| mem := map[string][]byte{} | ||
| applyOps(t, mem, gotPut) | ||
| require.Contains(t, mem, string(key)) | ||
| require.True(t, bytes.Equal(value, mem[string(key)])) | ||
| }) | ||
| } | ||
|
|
||
| func TestGrpcTranscoder_Property_RawDelete(t *testing.T) { | ||
| rapid.Check(t, func(t *rapid.T) { | ||
| key := rapid.SliceOf(rapid.Byte()).Draw(t, "key") | ||
| value := rapid.SliceOf(rapid.Byte()).Draw(t, "value") | ||
| tr := newGrpcGrpcTranscoder() | ||
|
|
||
| delReq := &pb.RawDeleteRequest{Key: key} | ||
| gotDel, err := tr.RawDeleteToRequest(delReq) | ||
| require.NoError(t, err) | ||
| require.False(t, gotDel.IsTxn) | ||
| require.Len(t, gotDel.Elems, 1) | ||
| require.Equal(t, kv.Del, gotDel.Elems[0].Op) | ||
| require.Equal(t, key, gotDel.Elems[0].Key) | ||
|
|
||
| mem := map[string][]byte{string(key): value} | ||
| applyOps(t, mem, gotDel) | ||
| _, ok := mem[string(key)] | ||
| require.False(t, ok) | ||
| }) | ||
| } | ||
|
|
||
| func TestGrpcTranscoder_Property_TxnOps(t *testing.T) { | ||
| rapid.Check(t, func(t *rapid.T) { | ||
| key := rapid.SliceOf(rapid.Byte()).Draw(t, "key") | ||
| value := rapid.SliceOf(rapid.Byte()).Draw(t, "value") | ||
| tr := newGrpcGrpcTranscoder() | ||
| mem := map[string][]byte{} | ||
|
|
||
| // TransactionalPut | ||
| txPutReq := &pb.PutRequest{Key: key, Value: value} | ||
| gotTxPut, err := tr.TransactionalPutToRequests(txPutReq) | ||
| require.NoError(t, err) | ||
| require.True(t, gotTxPut.IsTxn) | ||
| require.Equal(t, uint64(0), gotTxPut.StartTS) | ||
| require.Len(t, gotTxPut.Elems, 1) | ||
| require.Equal(t, kv.Put, gotTxPut.Elems[0].Op) | ||
| require.Equal(t, key, gotTxPut.Elems[0].Key) | ||
| require.Equal(t, value, gotTxPut.Elems[0].Value) | ||
| applyOps(t, mem, gotTxPut) | ||
| require.True(t, bytes.Equal(value, mem[string(key)])) | ||
|
|
||
| // TransactionalDelete | ||
| txDelReq := &pb.DeleteRequest{Key: key} | ||
| gotTxDel, err := tr.TransactionalDeleteToRequests(txDelReq) | ||
| require.NoError(t, err) | ||
| require.True(t, gotTxDel.IsTxn) | ||
| require.Equal(t, uint64(0), gotTxDel.StartTS) | ||
| require.Len(t, gotTxDel.Elems, 1) | ||
| require.Equal(t, kv.Del, gotTxDel.Elems[0].Op) | ||
| require.Equal(t, key, gotTxDel.Elems[0].Key) | ||
| applyOps(t, mem, gotTxDel) | ||
| _, ok := mem[string(key)] | ||
| require.False(t, ok) | ||
| }) | ||
| } | ||
|
|
||
| func applyOps(t interface { | ||
| Helper() | ||
| Errorf(string, ...interface{}) | ||
| FailNow() | ||
| }, mem map[string][]byte, group *kv.OperationGroup[kv.OP]) { | ||
| t.Helper() | ||
|
|
||
| for _, elem := range group.Elems { | ||
| switch elem.Op { | ||
| case kv.Put: | ||
| mem[string(elem.Key)] = append([]byte(nil), elem.Value...) | ||
| case kv.Del: | ||
| delete(mem, string(elem.Key)) | ||
| default: | ||
| require.Fail(t, "unknown operation", "op=%v", elem.Op) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package adapter | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/bootjp/elastickv/kv" | ||
| "github.com/stretchr/testify/require" | ||
| "pgregory.net/rapid" | ||
| ) | ||
|
|
||
| func TestRedisTranscoder_Property_Set(t *testing.T) { | ||
| rapid.Check(t, func(t *rapid.T) { | ||
| key := rapid.SliceOf(rapid.Byte()).Draw(t, "key") | ||
| value := rapid.SliceOf(rapid.Byte()).Draw(t, "value") | ||
| tr := newRedisTranscoder() | ||
|
|
||
| req, err := tr.SetToRequest(key, value) | ||
| require.NoError(t, err) | ||
| require.False(t, req.IsTxn) | ||
| require.Len(t, req.Elems, 1) | ||
| require.Equal(t, kv.Put, req.Elems[0].Op) | ||
| require.Equal(t, key, req.Elems[0].Key) | ||
| require.Equal(t, value, req.Elems[0].Value) | ||
| }) | ||
| } | ||
|
|
||
| func TestRedisTranscoder_Property_Delete(t *testing.T) { | ||
| rapid.Check(t, func(t *rapid.T) { | ||
| key := rapid.SliceOf(rapid.Byte()).Draw(t, "key") | ||
| tr := newRedisTranscoder() | ||
|
|
||
| reqDel, err := tr.DeleteToRequest(key) | ||
| require.NoError(t, err) | ||
| require.False(t, reqDel.IsTxn) | ||
| require.Len(t, reqDel.Elems, 1) | ||
| require.Equal(t, kv.Del, reqDel.Elems[0].Op) | ||
| require.Equal(t, key, reqDel.Elems[0].Key) | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| package store | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| "pgregory.net/rapid" | ||
| ) | ||
|
|
||
| var nonEmptyBytes = rapid.SliceOf(rapid.Byte()).Filter(func(b []byte) bool { return len(b) > 0 }) | ||
|
|
||
| func TestMVCCStore_Property_PutGet(t *testing.T) { | ||
| rapid.Check(t, func(t *rapid.T) { | ||
| key := nonEmptyBytes.Draw(t, "key") | ||
| value := rapid.SliceOf(rapid.Byte()).Draw(t, "value") | ||
| ts := rapid.Uint64Range(0, ^uint64(0)-100).Draw(t, "ts") | ||
|
|
||
| s := NewMVCCStore() | ||
| ctx := context.Background() | ||
|
|
||
| err := s.PutAt(ctx, key, value, ts, 0) | ||
| require.NoError(t, err) | ||
|
|
||
| actualTS, ok, err := s.LatestCommitTS(ctx, key) | ||
| require.NoError(t, err) | ||
| require.True(t, ok) | ||
|
|
||
| // 1. Get at the actual commit timestamp | ||
| got, err := s.GetAt(ctx, key, actualTS) | ||
| require.NoError(t, err) | ||
| require.Equal(t, value, got) | ||
|
|
||
| // 2. Get at a later timestamp | ||
| laterTS := rapid.Uint64Range(actualTS, ^uint64(0)).Draw(t, "laterTS") | ||
| gotLater, err := s.GetAt(ctx, key, laterTS) | ||
| require.NoError(t, err) | ||
| require.Equal(t, value, gotLater) | ||
|
|
||
| // 3. Get at an earlier timestamp should fail | ||
| if actualTS > 0 { | ||
| _, err := s.GetAt(ctx, key, actualTS-1) | ||
| require.ErrorIs(t, err, ErrKeyNotFound) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| func TestMVCCStore_Property_Delete(t *testing.T) { | ||
| rapid.Check(t, func(t *rapid.T) { | ||
| key := nonEmptyBytes.Draw(t, "key") | ||
| value := rapid.SliceOf(rapid.Byte()).Draw(t, "value") | ||
| ts := rapid.Uint64Range(0, ^uint64(0)-100).Draw(t, "ts") | ||
|
|
||
| s := NewMVCCStore() | ||
| ctx := context.Background() | ||
|
|
||
| // 1. Put | ||
| err := s.PutAt(ctx, key, value, ts, 0) | ||
| require.NoError(t, err) | ||
| actualPutTS := s.LastCommitTS() | ||
|
|
||
| // 2. Delete | ||
| delTS := rapid.Uint64Range(actualPutTS, ^uint64(0)-1).Draw(t, "delTS") | ||
| err = s.DeleteAt(ctx, key, delTS) | ||
| require.NoError(t, err) | ||
| actualDelTS := s.LastCommitTS() | ||
|
|
||
| // 3. GetAt(actualPutTS) should still see value (Snapshot Isolation) | ||
| got, err := s.GetAt(ctx, key, actualPutTS) | ||
| require.NoError(t, err) | ||
| require.Equal(t, value, got) | ||
|
|
||
| // 4. GetAt(actualDelTS) should see nothing | ||
| _, err = s.GetAt(ctx, key, actualDelTS) | ||
| require.ErrorIs(t, err, ErrKeyNotFound) | ||
| }) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.