Skip to content

⚡ Bolt: Use GCD background queue for concurrent file deletion#262

Open
acebytes wants to merge 1 commit into
mainfrom
bolt/gcd-background-deletion-3556899244841971268
Open

⚡ Bolt: Use GCD background queue for concurrent file deletion#262
acebytes wants to merge 1 commit into
mainfrom
bolt/gcd-background-deletion-3556899244841971268

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Replaced Task.detached with a checked continuation wrapping DispatchQueue.global.async for file removals.
🎯 Why: Task.detached stays on the cooperative thread pool. Using GCD explicitly offloads blocking I/O, allowing concurrent bulk file deletion without starving the cooperative executor.
📊 Impact: Prevents concurrency deadlocks during large cleanups.
🔬 Measurement: Observe UI responsiveness and lack of starvation during parallel cleanups.


PR created automatically by Jules for task 3556899244841971268 started by @acebytes

Replaced `Task.detached` with `withCheckedThrowingContinuation` and `DispatchQueue.global(qos: .userInitiated).async` in `CacheCleaner.swift`.

This prevents the exhaustion of the limited cooperative thread pool caused by running multiple concurrent, synchronous blocking I/O calls (`FileManager.removeItem`), thereby eliminating potential deadlocks during large cleanups.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant