🛡️ Sentinel: [CRITICAL] Fix Process Pipe Deadlock Vulnerability#265
🛡️ Sentinel: [CRITICAL] Fix Process Pipe Deadlock Vulnerability#265acebytes wants to merge 1 commit into
Conversation
Resolved a vulnerability where synchronous pipe reading inside `terminationHandler` could deadlock if the output exceeds the OS pipe buffer limit. The fix implements concurrent pipe draining using `readabilityHandler` and `NSLock`. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3204dcc58d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| lock.lock() | ||
| var finalStdout = stdoutData as Data | ||
| var finalStderr = stderrData as Data | ||
| lock.unlock() |
There was a problem hiding this comment.
The termination path copies stdoutData/stderrData immediately after setting readabilityHandler = nil, but that does not guarantee an already-dispatched handler has finished appending data. If a handler has already called availableData (consuming bytes from the pipe) and is still waiting to append when this snapshot is taken, those bytes are neither in finalStdout/finalStderr nor readable via readToEnd(), resulting in truncated output. In listLocalSnapshots, this can silently drop snapshot lines and cause the cleanup pass to skip deletions.
Useful? React with 👍 / 👎.
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Output pipes from
Processwere read synchronously inside theterminationHandler, which risks a deadlock if output > 64KB.🎯 Impact: The process execution could block forever and never terminate, freezing the cleanup intervention sequence.
🔧 Fix: Implemented concurrent pipe draining with
readabilityHandlerandNSLockto prevent the OS buffer from filling up.✅ Verification: Run
./scripts/test.sh.PR created automatically by Jules for task 3741752078601574940 started by @acebytes