fix(teams): add organization scope to membership operations #26964
Merged
keithwillcode merged 4 commits intomainfrom Jan 19, 2026
Merged
fix(teams): add organization scope to membership operations #26964keithwillcode merged 4 commits intomainfrom
keithwillcode merged 4 commits intomainfrom
Conversation
- Add organization scope validation to removeMember handler - Ensure team operations are scoped to users organization context - Update related tests
Contributor
E2E results are ready! |
- Add organizationId to test contexts - Add team.findMany mock for org validation - Add test cases for org scope validation
6 tasks
…eMemberService - Add findByIdsAndOrgId method to TeamRepository - Inject TeamRepository into LegacyRemoveMemberService via constructor - Update RemoveMemberServiceFactory to instantiate and inject TeamRepository - Update tests to mock TeamRepository instead of direct prisma calls Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
keithwillcode
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds organization scope validation to the
removeMemberhandler when PBAC is disabled. Org admin operations now verify that target teams belong to the admin's organization before proceeding.Changes
IRemoveMemberService.tsorganizationIdto contextremoveMember.handler.tsLegacyRemoveMemberService.tsremoveMember.handler.test.tsTechnical Details
New validation in
LegacyRemoveMemberService.checkRemovePermissions():How should this be tested?
Mandatory Tasks