Skip to content

fix(postcss-linaria): enable CI tests #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anber merged 2 commits into from
Jan 26, 2026
+29 −5
Merged

fix(postcss-linaria): enable CI tests #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
309b720
fix(postcss-linaria): enable CI tests
Anber Jan 26, 2026
4c46401
chore: add changeset for postcss-linaria fixes
Anber Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/postcss-linaria-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@linaria/postcss-linaria': patch
---

Fix `@linaria/postcss-linaria` placeholder naming and source location correction, and ensure stylelint integration resolves configs correctly.
12 changes: 12 additions & 0 deletions packages/postcss-linaria/__tests__/stylelint.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { resolve } from 'path';

import stylelint, { type Config } from 'stylelint';

// importing from the package would create circular dependency
Expand All @@ -7,6 +9,11 @@ import config from '../../stylelint-config-standard-linaria/src';

// note: need to run pnpm install to pick up updates from any parse/stringify changes
describe('stylelint', () => {
const configBasedir = resolve(
__dirname,
'../../stylelint-config-standard-linaria'
);

it('should not error with valid syntax', async () => {
const source = `
css\`
Expand All @@ -26,6 +33,7 @@ describe('stylelint', () => {
const result = await stylelint.lint({
code: source,
config: config as Config,
configBasedir,
});

expect(result.errored).toEqual(false);
Expand All @@ -46,6 +54,7 @@ describe('stylelint', () => {
},
} as Config,
fix: true,
configBasedir,
});
expect(result.errored).toEqual(false);
expect(result.output).toMatchInlineSnapshot(`
Expand All @@ -71,6 +80,7 @@ describe('stylelint', () => {
},
} as Config,
fix: true,
configBasedir,
});
expect(result.errored).toEqual(false);
expect(result.output).toMatchInlineSnapshot(`
Expand All @@ -97,6 +107,7 @@ describe('stylelint', () => {
},
} as Config,
fix: true,
configBasedir,
});
expect(result.output).toMatchInlineSnapshot(`
"
Expand Down Expand Up @@ -124,6 +135,7 @@ describe('stylelint', () => {
indentation: 4,
},
} as Config,
configBasedir,
});

expect(result.errored).toEqual(false);
Expand Down
1 change: 1 addition & 0 deletions packages/postcss-linaria/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"build:esm": "babel src --out-dir esm --extensions '.js,.jsx,.ts,.tsx' --source-maps --delete-dir-on-start",
"build:lib": "cross-env NODE_ENV=legacy babel src --out-dir lib --extensions '.js,.jsx,.ts,.tsx' --source-maps --delete-dir-on-start",
"typecheck": "tsc --noEmit --composite false",
"test": "jest --config ../../jest.config.js --rootDir .",
"watch": "pnpm build:lib --watch & pnpm build:esm --watch & pnpm build:declarations --watch"
},
"dependencies": {
Expand Down
11 changes: 7 additions & 4 deletions packages/postcss-linaria/src/locationCorrection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ const correctLocation = (
loc: Position,
baseIndentations: Map<number, number>,
sourceAsString: string,
prefixOffsets?: { lines: number; offset: number }
prefixOffsets?: { lines: number; offset: number },
kind: 'start' | 'end' = 'start'
): Position => {
if (!node.quasi.loc || !node.quasi.range) {
return loc;
Expand All @@ -19,7 +20,7 @@ const correctLocation = (
const nodeLoc = node.quasi.loc;
const nodeOffset = node.quasi.range[0];
let lineOffset = nodeLoc.start.line - 1;
let newOffset = loc.offset + nodeOffset + 1;
let newOffset = loc.offset + nodeOffset + (kind === 'start' ? 1 : 0);
let currentLine = 1;
let columnOffset = nodeLoc.start.column + 1;

Expand Down Expand Up @@ -276,7 +277,8 @@ export function locationCorrectionWalker(
node.source.start,
baseIndentations,
sourceAsString,
root.raws.linariaPrefixOffsets
root.raws.linariaPrefixOffsets,
'start'
);
}
if (node.source?.end) {
Expand All @@ -285,7 +287,8 @@ export function locationCorrectionWalker(
node.source.end,
baseIndentations,
sourceAsString,
root.raws.linariaPrefixOffsets
root.raws.linariaPrefixOffsets,
'end'
);
}
};
Expand Down
2 changes: 1 addition & 1 deletion packages/postcss-linaria/src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const isRuleSet = (sourceAsString: string, indexAfterExpression: number) => {
);
};

export const placeholderText = 'pcss_lin';
export const placeholderText = 'pcss-lin';

export const createPlaceholder = (
i: number,
Expand Down
3 changes: 3 additions & 0 deletions turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
"@linaria/react#test": {
"dependsOn": ["@linaria/core#build"]
},
"@linaria/postcss-linaria#test": {
"dependsOn": ["@linaria/postcss-linaria#build"]
},
"@linaria/testkit#test": {
"dependsOn": ["^build"]
},
Expand Down