[Workers] Add existing project deployment guide for React + Vite#31275
Open
thomasgauvin wants to merge 2 commits into
Open
[Workers] Add existing project deployment guide for React + Vite#31275thomasgauvin wants to merge 2 commits into
thomasgauvin wants to merge 2 commits into
Conversation
github-actions
Bot
assigned
GregBrimble,
irvinebroque,
korinne,
MattieTK,
mikenomitch,
vy-ton and
WalshyDev
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
thomasgauvin
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
irvinebroque,
korinne,
mikenomitch and
vy-ton
as code owners
Contributor
Review❌ Review failed for commit |
Contributor
Author
|
This first PR is focused on extracting the Vite Plugin tutorial into partials that can be reused in the Framework Guides 'deploy your project' sections |
ask-bonk
Bot
added
documentation
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
6 issues found. 3 inline suggestions posted for the partials; 3 additional issues noted below.
HIGH
src/content/docs/workers/framework-guides/web-apps/react.mdxline 7: Thedescriptionfrontmatter is outdated. It only mentions creating a new project, but the page now covers deploying existing projects too. Update it to reflect both paths.src/content/docs/workers/framework-guides/web-apps/react.mdxlines 13–15:Badge,Description, andInlineBadgeare imported but never used. Remove them from the import block.
MEDIUM
src/content/docs/workers/vite-plugin/tutorial.mdxline 8: Therevieweddate is stale (2025-04-04) after this significant refactor. Consider updating it if the content was verified end-to-end.
Out of scope
src/content/docs/workers/framework-guides/web-apps/react.mdxline 208:./worker/index.tsshould be in backticks per the style guide, but this is a pre-existing issue.
Contributor
|
Labels applied: Posted a review with 3 inline suggestions and a summary comment covering 6 issues. HIGH
MEDIUM
Out of scope
PR otherwise looks structurally sound: no unescaped MDX characters, links are root-relative with trailing slashes, |
Contributor
…ide violations, and use toml in WranglerConfig
thomasgauvin
force-pushed
the
react-vite-existing-project-guide
branch
from
97fbd75 to
5cbf41b
Compare
Contributor
Author
|
/bonk rereview |
Contributor
There was a problem hiding this comment.
All issues from the first review have been resolved. One new style guide issue found.
MEDIUM
src/content/partials/workers/vite-plugin/add-api-worker.mdxline 11: Worker code must useTypeScriptExample, not a baretsfence. Update the import on line 5 to includeTypeScriptExampleand wrap the code block in<TypeScriptExample filename="worker/index.ts">.
Contributor
|
All issues from the first review have been resolved:
One new issue found and posted to PR #31275: MEDIUM
|
Contributor
|
CI run failed: build logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the React + Vite framework guide to include instructions for deploying an existing React + Vite project to Cloudflare Workers, not just creating a new one from scratch.
The guide now uses tabs to separate the two paths:
Reusable steps from the Vite plugin tutorial have been extracted into shared partials under
src/content/partials/workers/vite-plugin/. Both the tutorial and the React framework guide now consume these partials, eliminating duplication and making the content easier to reuse for other framework guides in the future.Partial files created:
add-dependencies.mdxadd-plugin-to-vite-config.mdxcreate-wrangler-config.mdxupdate-gitignore.mdxrun-dev-server.mdxbuild-app.mdxpreview-app.mdxdeploy.mdxadd-tsconfig-worker.mdxadd-worker-config.mdxadd-api-worker.mdxScreenshots (optional)
Documentation checklist