fix(button): refine hover states#576
Open
mattrothenberg wants to merge 2 commits into
Open
Conversation
commit: |
Contributor
Docs PreviewCommit: |
Contributor
Visual Regression Report — 3 changed, 11 unchanged3 screenshot(s) with visual changes: Button / Variant: Secondary314 px (0.31%) changed
Button / With Icon422 px (0.42%) changed
Button / Loading State195 px (0.19%) changed
11 screenshot(s) unchanged
Generated by Kumo Visual Regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pnpm --filter @cloudflare/kumo test button
pnpm --filter @cloudflare/kumo lint
Reviews
bonk has reviewed the change
automated review not possible because: small visual token-only button variant update
Tests
Tests included/updated
Additional testing not necessary because: covered by existing button tests and manual local visual review