Skip to content

Handle student & coach event emailing as separate#2127

Closed
gnclmorais wants to merge 1 commit intocodebar:masterfrom
gnclmorais:split-background-jobs
Closed

Handle student & coach event emailing as separate#2127
gnclmorais wants to merge 1 commit intocodebar:masterfrom
gnclmorais:split-background-jobs

Conversation

@gnclmorais
Copy link
Copy Markdown
Contributor

@gnclmorais gnclmorais commented Oct 25, 2024

Send them both in the background, separately. This should help with the timeouts we have sometimes on Heroku, I hope. Thoughts @matyikriszta? Do you think we could spin up a review-app of this on Heroku or something, and trigger test emails?

In any case, I revisited #1750 and got it back to shape. ✨ That one should definitely help in sending less emails.

Send them both in the background, separately. This should help with
the timeouts we have sometimes on Heroku.
@matyikriszta
Copy link
Copy Markdown
Contributor

matyikriszta commented Oct 26, 2024

@gnclmorais we currently can't set up Review apps, we'd never set that feature up on Heroku and in the app and since we are trying to move away from Heroku I do not want to invest time in it. We could potentially test on staging, I do wonder if we have enough seed data to meaningfully test this feature, we'd have to have thousands of members subscribed to a chapter to really be able to test it. I think this should help already, one other thing we could do is set the coach emails to deliver_later. Not sure how this works together with the handle_asynchronously method. Coach spots do not fill up as fast as student spots so I think it's not a big issue if everyone doesn't get the email at about the same time.

@till
Copy link
Copy Markdown
Collaborator

till commented Apr 16, 2026

@gnclmorais @matyikriszta — hey 👋🏼 — we doing some housekeeping and are gonna close this PR as it's a bit stale.

We also haven't seen timeouts recently. 🥳

I think for the future of email sending, we should explore the idea of using a template and batch sending via Sendgrid/Twillio in order to make it more resilient. Then no async is required here as we can submit up to ~1000 emails in one request.

@till till closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants