Handle student & coach event emailing as separate#2127
Handle student & coach event emailing as separate#2127gnclmorais wants to merge 1 commit intocodebar:masterfrom
Conversation
Send them both in the background, separately. This should help with the timeouts we have sometimes on Heroku.
|
@gnclmorais we currently can't set up Review apps, we'd never set that feature up on Heroku and in the app and since we are trying to move away from Heroku I do not want to invest time in it. We could potentially test on staging, I do wonder if we have enough seed data to meaningfully test this feature, we'd have to have thousands of members subscribed to a chapter to really be able to test it. I think this should help already, one other thing we could do is set the coach emails to |
|
@gnclmorais @matyikriszta — hey 👋🏼 — we doing some housekeeping and are gonna close this PR as it's a bit stale. We also haven't seen timeouts recently. 🥳 I think for the future of email sending, we should explore the idea of using a template and batch sending via Sendgrid/Twillio in order to make it more resilient. Then no async is required here as we can submit up to ~1000 emails in one request. |
Send them both in the background, separately. This should help with the timeouts we have sometimes on Heroku, I hope. Thoughts @matyikriszta? Do you think we could spin up a review-app of this on Heroku or something, and trigger test emails?
In any case, I revisited #1750 and got it back to shape. ✨ That one should definitely help in sending less emails.