test: add Storybook coverage for Tasks settings

Change-Id: I610ed14466ef41cd45a263a2b48740d3f9aa0c8d
Signed-off-by: Thomas Kosiewski <[email protected]>

Author: ThomasK33

.storybook/mocks/orpc.ts

@@ -10,6 +10,7 @@ import type { WorkspaceChatMessage, ProvidersConfigMap } from "@/common/orpc/typ
 import type { ChatStats } from "@/common/types/chatStats";
 import { DEFAULT_RUNTIME_CONFIG } from "@/common/constants/workspace";
 import { createAsyncMessageQueue } from "@/common/utils/asyncMessageQueue";
+import type { TaskSettings } from "@/common/orpc/schemas/taskSettings";
 
 /** Session usage data structure matching SessionUsageFileSchema */
 export interface MockSessionUsage {
@@ -82,6 +83,8 @@ export interface MockORPCClientOptions {
   >;
   /** MCP test results - maps server name to tools list or error */
   mcpTestResults?: Map<string, { success: true; tools: string[] } | { success: false; error: string }>;
+  /** Task settings (maxParallelAgentTasks + maxTaskNestingDepth) */
+  taskSettings?: TaskSettings;
 }
 
 /**
@@ -114,11 +117,17 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
     sessionUsage = new Map(),
     mcpServers = new Map(),
     mcpOverrides = new Map(),
+    taskSettings: rawTaskSettings,
     mcpTestResults = new Map(),
   } = options;
 
   const workspaceMap = new Map(workspaces.map((w) => [w.id, w]));
 
+
+  let taskSettings: TaskSettings = rawTaskSettings ?? {
+    maxParallelAgentTasks: 3,
+    maxTaskNestingDepth: 3,
+  };
   const mockStats: ChatStats = {
     consumers: [],
     totalTokens: 0,
@@ -135,6 +144,12 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
         _input.texts.map(() => 0),
       calculateStats: async () => mockStats,
     },
+    tasks: {
+      getTaskSettings: async () => taskSettings,
+      setTaskSettings: async (input: TaskSettings) => {
+        taskSettings = input;
+      },
+    },
     server: {
       getLaunchProject: async () => null,
       getSshHost: async () => null,

src/browser/stories/App.settings.stories.tsx

@@ -10,6 +10,7 @@
  */
 
 import type { APIClient } from "@/browser/contexts/API";
+import type { TaskSettings } from "@/common/orpc/schemas/taskSettings";
 import { appMeta, AppWithMocks, type AppStory } from "./meta.js";
 import { createWorkspace, groupWorkspacesByProject } from "./mockFactory";
 import { selectWorkspace } from "./storyHelpers";
@@ -32,6 +33,8 @@ function setupSettingsStory(options: {
   providersList?: string[];
   /** Pre-set experiment states in localStorage before render */
   experiments?: Partial<Record<string, boolean>>;
+  /** Initial task settings values */
+  taskSettings?: TaskSettings;
 }): APIClient {
   const workspaces = [createWorkspace({ id: "ws-1", name: "main", projectName: "my-app" })];
 
@@ -47,6 +50,7 @@ function setupSettingsStory(options: {
 
   return createMockORPCClient({
     projects: groupWorkspacesByProject(workspaces),
+    taskSettings: options.taskSettings,
     workspaces,
     providersConfig: options.providersConfig ?? {},
     providersList: options.providersList ?? ["anthropic", "openai", "xai"],
@@ -168,6 +172,32 @@ export const ModelsConfigured: AppStory = {
   },
 };
 
+/** Tasks section - shows agent task settings */
+export const Tasks: AppStory = {
+  render: () => (
+    <AppWithMocks
+      setup={() =>
+        setupSettingsStory({
+          taskSettings: {
+            maxParallelAgentTasks: 5,
+            maxTaskNestingDepth: 2,
+          },
+        })
+      }
+    />
+  ),
+  play: async ({ canvasElement }: { canvasElement: HTMLElement }) => {
+    await openSettingsToSection(canvasElement, "tasks");
+
+    const body = within(canvasElement.ownerDocument.body);
+    await body.findByText(/Agent task limits/i);
+
+    // Ensure the values were loaded from the API mock (not just initial defaults)
+    await body.findByDisplayValue("5");
+    await body.findByDisplayValue("2");
+  },
+};
+
 /** Experiments section - shows available experiments */
 export const Experiments: AppStory = {
   render: () => <AppWithMocks setup={() => setupSettingsStory({})} />,