checkstl.cpp: removed unnessary condition from LoopAnalyzer::findAlgo()

firewave · firewave · commit 9947de9f8e7b · 2026-06-22T11:17:39.000+02:00
diff --git a/lib/checkstl.cpp b/lib/checkstl.cpp
@@ -2886,10 +2886,6 @@ namespace {
             }
         }
     private:
-        bool isLoopVarChanged() const {
-            return mVarsChanged.count(mLoopVar->varId()) > 0;
-        }
-
         bool isModified(const Token* tok) const
         {
             if (tok->variable() && tok->variable()->isConst())
@@ -2942,8 +2938,7 @@ namespace {
         {
             if (!valid())
                 return "";
-            bool loopVarChanged = isLoopVarChanged();
-            if (!loopVarChanged && mVarsChanged.empty()) {
+            if (mVarsChanged.empty()) {
                 if (hasGotoOrBreak())
                     return "";
                 bool alwaysTrue = true;

Original file line number	Diff line number	Diff line change
`@@ -2886,10 +2886,6 @@ namespace {`
`2886`	`2886`	`}`
`2887`	`2887`	`}`
`2888`	`2888`	`private:`
`2889`		`- bool isLoopVarChanged() const {`
`2890`		`- return mVarsChanged.count(mLoopVar->varId()) > 0;`
`2891`		`- }`
`2892`		`-`
`2893`	`2889`	`bool isModified(const Token* tok) const`
`2894`	`2890`	`{`
`2895`	`2891`	`if (tok->variable() && tok->variable()->isConst())`
`@@ -2942,8 +2938,7 @@ namespace {`
`2942`	`2938`	`{`
`2943`	`2939`	`if (!valid())`
`2944`	`2940`	`return "";`
`2945`		`- bool loopVarChanged = isLoopVarChanged();`
`2946`		`- if (!loopVarChanged && mVarsChanged.empty()) {`
	`2941`	`+ if (mVarsChanged.empty()) {`
`2947`	`2942`	`if (hasGotoOrBreak())`
`2948`	`2943`	`return "";`
`2949`	`2944`	`bool alwaysTrue = true;`