[WORKFLOW SDK BUG] Orchestration nomenclature & Protobuf concerns bleed through to API surface

[olitomlinson]

Expected Behavior

Setting a reuse policy should be as simple and intuitive as using an enum e.g.

reuse_policy = ReuseIdPolicy.IGNORE

workflow_client.schedule_new_workflow(
    workflow=tracker_workflow,
    instance_id=str(run_id),
    input={},
    reuse_id_policy=reuse_policy  # Prevents "workflow already exists" errors
)

Actual Behavior

1. Orchestration is an underlying durabletask term, this should not bleed through to the public API
2. Protobuf concerns should not bleed through to the public API

# Create reuse policy to ignore if workflow already exists (handles race conditions)
reuse_policy = pb.OrchestrationIdReusePolicy(action=pb.IGNORE)

workflow_client.schedule_new_workflow(
    workflow=tracker_workflow,
    instance_id=str(run_id),
    input={},
    reuse_id_policy=reuse_policy  # Prevents "workflow already exists" errors
)

Release Note

RELEASE NOTE:

[acroca]

The Go SDK also uses the proto object when providing those policies: source

[olitomlinson]

@acroca yeah, It's a problem, we shouldn't have internal protos slipping into the DevEx of any of the SDKs

[dapr-bot]

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

[acroca]

Started this work in dapr/durabletask-python#51, removing the proto dependency in durabletask. Once it's gone from durabletask, I'll do a similar change here.

[dapr-bot]

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

[dapr-bot]

This issue has been automatically closed because it was marked stale with no further activity for 7 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.