fix: guard GetProTxHash() behind is_masternode check, add CQuorum safety assert

In TriggerQuorumDataRecoveryThreads, avoid calling GetProTxHash() in
observer mode where it returns a null hash.  Also adds missing const
qualifier and fixes operator spacing.

Assert m_quorum_base_block_index in CQuorum constructor, consistent
with the existing qc != nullptr assertion.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/llmq/net_quorum.cpp

@@ -445,15 +445,14 @@ void NetQuorum::TriggerQuorumDataRecoveryThreads(gsl::not_null<const CBlockIndex
 {
     if (!m_quorums_recovery) return;
 
-    bool is_masternode = m_role->IsMasternode();
-
-    LogPrint(BCLog::LLMQ, "NetQuorum::%s -- Process block %s\n", __func__, block_index->GetBlockHash().ToString());
+    const bool is_masternode = m_role->IsMasternode();
+    const uint256 proTxHash = is_masternode ? m_role->GetProTxHash() : uint256{};
 
-    const uint256 proTxHash = m_role->GetProTxHash();
+    LogPrint(BCLog::LLMQ, "NetQuorum::%s -- Process block %s as protx_hash=%s\n", __func__, block_index->GetBlockHash().ToString(), proTxHash.ToString());
 
     for (const auto& params : Params().GetConsensus().llmqs) {
         auto vecQuorums = m_qman.ScanQuorums(params.type, block_index, params.keepOldConnections);
-        const bool fWeAreQuorumTypeMember = is_masternode &&std::ranges::any_of(vecQuorums, [&proTxHash](const auto& pQuorum) {
+        const bool fWeAreQuorumTypeMember = is_masternode && std::ranges::any_of(vecQuorums, [&proTxHash](const auto& pQuorum) {
             return pQuorum->IsValidMember(proTxHash);
         });
 

src/llmq/quorums.cpp

@@ -111,6 +111,7 @@ CQuorum::CQuorum(const Consensus::LLMQParams& _params, CBLSWorker& _blsWorker,
     blsCache{_blsWorker}
 {
     assert(qc != nullptr);
+    assert(m_quorum_base_block_index != nullptr);
 }
 
 bool CQuorum::SetVerificationVector(const std::vector<CBLSPublicKey>& quorumVecIn)